Skip to content

Implement new irrigation scheme into standalone JULES#480

Open
Heather Rumbold (hsrumbold) wants to merge 6 commits into
MetOffice:mainfrom
hsrumbold:tile_irigation
Open

Implement new irrigation scheme into standalone JULES#480
Heather Rumbold (hsrumbold) wants to merge 6 commits into
MetOffice:mainfrom
hsrumbold:tile_irigation

Conversation

@hsrumbold
Copy link
Copy Markdown

@hsrumbold Heather Rumbold (hsrumbold) commented May 6, 2026

PR Summary

Sci/Tech Reviewer: Maggie (@maggiehendry)
Code Reviewer: James Bruten (@james-bruten-mo)

The LFRic_apps branch adds dependancies required for the JULES standalone irrigation code. Science isn't yet switched on and working in LFRic yet (but will be in a later issue).

  • See linked JULES PR for further details - MetOffice/jules#107
  • Also linked to MetOffice/um#85

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - tile_irigation_test_lfric/run2

Suite Information

Item Value
Suite Name tile_irigation_test_lfric/run2
Suite User heather.rumbold
Workflow Start 2026-05-06T12:44:48
Groups Run all
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules hsrumbold/jules_fork@new_migrated_branch_tile_irrigation True
lfric_apps hsrumbold/lfric_apps_fork@tile_irigation False
lfric_core MetOffice/lfric_core@2026.03.2 True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.2 True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@2026.03.2 True

Task Information

❌ failed tasks - 2
Task State
check_lfric_atm_nwp_gal9-C12_ex1a_cce_fast-debug-64bit-crun1 failed
check_lfric_coupled_nwp_gal9-C48_ex1a_cce_fast-debug-64bit failed
✅ succeeded tasks - 1509
⌛ waiting tasks - 1
Task State
housekeep_ex1a waiting

LFRic_apps has a couple of KGO failures BUT these are on the HPC and the same jobs on Azure Spice pass fine. We think this is a difference in precision across the platforms - hopefully thats ok!

trac.log output after updating the checksum files on my branch:

Test Suite Results - lfric_apps - tile_irigation_test_lfric/run2

Suite Information

Item Value
Suite Name tile_irigation_test_lfric/run2
Suite User heather.rumbold
Workflow Start 2026-05-06T12:44:48
Groups Run all
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules hsrumbold/jules_fork@new_migrated_branch_tile_irrigation True
lfric_apps hsrumbold/lfric_apps_fork@tile_irigation False
lfric_core MetOffice/lfric_core@2026.03.2 True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.2 True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@2026.03.2 True

Task Information

✅ succeeded tasks - 1512

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label May 6, 2026
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels May 6, 2026
@hsrumbold Heather Rumbold (hsrumbold) marked this pull request as ready for review May 6, 2026 15:02
@hsrumbold Heather Rumbold (hsrumbold) requested review from Pierre Siddall (Pierre-siddall) and removed request for a team May 6, 2026 15:02
@hsrumbold Heather Rumbold (hsrumbold) added Linked Jules This PR is linked to a MetOffice/jules PR KGO This PR contains changes to KGO labels May 6, 2026
Copy link
Copy Markdown
Contributor

@maggiehendry Maggie (maggiehendry) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB. The KGO has been updated on the HPC as the same tasks passed on Azure Spice. The checksums have already been updated on the trunk though, so they will need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA KGO This PR contains changes to KGO Linked Jules This PR is linked to a MetOffice/jules PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants