smooth lambda#476
Open
Adrian Lock (Adrian-Lock) wants to merge 12 commits into
Open
Conversation
…n905c_smooth_lambda
iboutle
reviewed
May 5, 2026
iboutle
approved these changes
May 7, 2026
P-Burns
reviewed
May 12, 2026
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: P-Burns
Code Reviewer: Pierre Siddall (@Pierre-siddall)
Add a new option for free_atm_mix to calculate a vertically smoother mixing length. Under the existing options, the mixing length is constant within turbulent layers (defined as where the Richardson number is subcritical), except as it approaches the surface where it tends towards the height above the surface. This reduction represents the suppression of the scale of vertical mixing by the physical presence of the boundary. In this new option we apply the same principle to the top and bottom boundaries of every turbulent layer, thereby making smoother transitions in the mixing length between layers of the atmosphere.
Equivalent changes in the UM at vn14.1: vn14.1_smooth_lambda
closes #159
Code Quality Checklist
Testing
I have activated the new option in the comorph_dev configuration and so the kgo is broken for those tasks.
trac.log
Test Suite Results - lfric_apps - main905c_smooth_lambda/run7
Suite Information
Task Information
❌ failed tasks - 6
⌛ waiting tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
Needs to be added to the Boundary Layer documentation paper but will have to wait until it is ported. I've opened issue #481 to do this separately.
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review