Feature/hierarchical-native-script-support#206
Open
Andre-Diamond wants to merge 8 commits intomainfrom
Open
Conversation
- Added `getCanonicalWalletAddress` function to standardize wallet address retrieval based on wallet type in `useWalletBalances.ts`. - Refactored balance fetching logic to utilize the new canonical address function. - Improved error handling for multisig wallet construction in the API endpoint, falling back to decoding stored CBOR for imported wallets. - Introduced native script utilities in `nativeScriptUtils.ts` for decoding, converting, and analyzing native scripts. - Added comprehensive tests for the new native script utilities, covering various scenarios including hierarchical and deeply nested scripts. - Updated `common.ts` to leverage new native script utilities for wallet construction. - Cleaned up unused code and improved overall structure for better maintainability.
…ction signing logic
…ipt recovery wallet
…osit handling - Introduced a new `buildStakingActionConfigs` function to streamline staking action configurations. - Refactored the `StakeButton` component to utilize the new action configuration system, improving code clarity and maintainability. - Implemented logic to handle stake key deposits dynamically based on the selected staking action. - Enhanced transaction signing logic in `useTransaction` to account for stake key deposit adjustments. - Updated `getTxBuilder` to explicitly provide stake key deposit parameters for deterministic transaction behavior.
- Improved proxy merging logic to combine API proxies with store-enriched data, ensuring accurate representation of available proxies. - Updated transaction creation process to handle Discord notifications with error handling, ensuring that transaction success is not dependent on notification delivery. - Refactored signer description rendering in transaction cards for better readability and maintainability. - Enhanced wallet access control logic to support multiple requester addresses, improving security and flexibility.
- Updated type annotations in ProxyDataLoader, ProxyControl, and ProxyTransferStep components to ensure better type safety and prevent potential runtime errors. - Enhanced error handling in useWalletBalances to gracefully manage 404 errors, improving user experience for unused addresses. - Refactored wallet balance fetching logic to utilize canonical addresses, ensuring consistency across wallet types. - Introduced utility functions for better management of payment signature scripts and native script handling in common and nativeScriptUtils modules.
- Introduced useMemo for stable wallet arrays in balance fetching to prevent unnecessary re-renders. - Enhanced useUserWallets to utilize useMemo for mapping wallets, improving performance and readability. - Updated useWalletBalances to ensure cleanup of in-flight processing on unmount, enhancing resource management. - Improved error handling for wallet address mismatches in payment scripts, ensuring consistency across wallet types.
- Replaced hardcoded deposit values with constants from `protocol-deposit-constants` for DRep deregistration in `offchain.ts` and `retire.tsx`. - Updated transaction handling logic in `useTransaction` to account for DRep deposit adjustments. - Refactored `getTxBuilder` to use the new deposit constant for staking. - Removed the deprecated `staking-constants.ts` file to streamline codebase and improve maintainability.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protocol-deposit-constantsfor DRep deregistration inoffchain.tsandretire.tsx.useTransactionto account for DRep deposit adjustments.getTxBuilderto use the new deposit constant for staking.staking-constants.tsfile to streamline codebase and improve maintainability.