Skip to content

Fix Incorrect handling of Lat and Long from EXIF data for S&W coords #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xkello wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Incorrect handling of Lat and Long from EXIF data for S&W coords #4690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/inputexpressionfunctions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,12 @@ QVariant ReadExifLatitude::func( const QVariantList &values, const QgsExpression
if ( resultString.isEmpty() )
return QVariant();

return QVariant( InputUtils::convertCoordinateString( resultString ) );
double lat = InputUtils::convertCoordinateString( resultString );
QString latRef = AndroidUtils::readExif( filepath, QStringLiteral( "GPSLatitudeRef" ) );
if ( lat > 0.0 && latRef.startsWith( QLatin1Char( 'S' ), Qt::CaseInsensitive ) )
lat = -lat;
return QVariant( lat );

#elif defined( Q_OS_IOS )
double lat = IosUtils::readExif( filepath, GPS_LAT_TAG ).toDouble();
QString latRef = IosUtils::readExif( filepath, QStringLiteral( "GPSLatitudeRef" ) );
Expand All @@ -81,7 +86,12 @@ QVariant ReadExifLongitude::func( const QVariantList &values, const QgsExpressio
if ( resultString.isEmpty() )
return QVariant();

return QVariant( InputUtils::convertCoordinateString( resultString ) );
double lon = InputUtils::convertCoordinateString( resultString );
QString lonRef = AndroidUtils::readExif( filepath, QStringLiteral( "GPSLongitudeRef" ) );
if ( lon > 0.0 && lonRef.startsWith( QLatin1Char( 'W' ), Qt::CaseInsensitive ) )
lon = -lon;
return QVariant( lon );

#elif defined( Q_OS_IOS )
double lon = IosUtils::readExif( filepath, GPS_LON_TAG ).toDouble();
QString lonRef = IosUtils::readExif( filepath, QStringLiteral( "GPSLongitudeRef" ) );
Expand Down
Loading