Skip to content

Fix app freeze when adding photos to non-spatial layer - #4678

Open
xkello wants to merge 1 commit into
masterfrom
bugfix/app-freeze-on-add-photo-to-non-spatial-layer
Open

Fix app freeze when adding photos to non-spatial layer#4678
xkello wants to merge 1 commit into
masterfrom
bugfix/app-freeze-on-add-photo-to-non-spatial-layer

Conversation

@xkello

@xkello xkello commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

Adding a photo (or any linked feature) to a relation while its parent feature was still unsaved caused the app to freeze. This is the same root cause and fix pattern as the freeze fixed in #3483, which added forceActiveFocus() before creating/opening linked features elsewhere in this file that fix was never applied to the relation drawer's own "Add feature" button and list item clicks, leaving those two entry points still exposed.

Fixes: #4636

What Changed

MMFormRelationEditor.qml: call root.forceActiveFocus() before createLinkedFeature/openLinkedFeature in the relation drawer's onButtonClicked and onFeatureClicked handlers.

Behaviour

  • Before: adding a child feature to an unsaved parent while a text input (e.g. the drawer's search box) still had focus/keyboard open could freeze the app.
  • After: focus is cleared first, so the keyboard commits/closes before the parent save is triggered, and the freeze no longer occurs.

@xkello
xkello requested a review from Withalion August 27, 2026 13:49
@github-actions

Copy link
Copy Markdown

Coverage Report for CI Build 33078312387

Warning

No base build found for commit fd52673 on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 59.112%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15704
Covered Lines: 9283
Line Coverage: 59.11%
Coverage Strength: 97.04 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 72261 dmg Expires: 25/11/2026 #7226
linux Build 📬 Mergin Maps 72521 x86_64 Expires: 25/11/2026 #7252
win64 Build 📬 Mergin Maps 64281 win64 Expires: 25/11/2026 #6428
Android Build 📬 Mergin Maps 853651 APK [arm64-v8a] Expires: 25/11/2026 #8536
📬 Mergin Maps 853651 APK [arm64-v8a] Google Play Store #8536
Android Build 📬 Mergin Maps 853611 APK [armeabi-v7a] Expires: 25/11/2026 #8536
📬 Mergin Maps 853611 APK [armeabi-v7a] Google Play Store #8536
iOS Build 📬 Build number: 26.08.947811 #9478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App freezes when adding photos to non-spatial layer

1 participant