Add Trimble position provider - #4641
Open
Withalion wants to merge 39 commits into
Open
Conversation
Some test cases with bluetooth preprocessor guard were not run, because there was missing import for mmconfig.h
Improve position data parsing, antenna height handling.
📦 Build Artifacts Ready
|
Testing Comments — Android (Trimble Mobile Manager integration)
Screen_Recording_20260812_144154.mp4
Screen_Recording_20260811_153349.2.mp4 |
With trimble position provider after startup it looked like users started Trimble app instead of MM. We add a bit of delay, so loading is more natural.
Collaborator
Author
|
Issues found in testing should be fixed now:
|
Coverage Report for CI Build 33050183319Warning No base build found for commit Coverage: 59.543%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Testing 2
|
📦 Build Artifacts Ready
|
Testing 3
Enhancement: #4673 |
Collaborator
Author
|
Let's make the Android issue as enhancement for future |
tomasMizera
reviewed
Aug 27, 2026
| { QStringLiteral( "NAD83(MA11) (EPOCH:2010)" ), QStringLiteral( "EPSG:6324" ) }, | ||
| { QStringLiteral( "NAD83(PA11) (EPOCH:2010)" ), QStringLiteral( "EPSG:6321" ) }, | ||
| { QStringLiteral( "NZGD2000" ), QStringLiteral( "EPSG:4959" ) }, | ||
| { QStringLiteral( "OSNetv2009" ), QStringLiteral( "EPSG:4277" ) }, // TODO: create 3D CRS here |
| emit positionChanged( GeoPosition() ); | ||
| } | ||
|
|
||
| void TrimblePositionProvider::openAntennaHeightPage() |
Collaborator
There was a problem hiding this comment.
Why not bothering with this native code in trimbleregistration?
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/MerginMaps/product/issues/121
For easier integration with Trimble external GNSS devices a new provider has been added. The setup has been essentially changed to be "one-click". Trimble Mobile Manager (TMM) companion app is required for proper setup.
New Workflows:
screen-20260824-125532.mp4
screen-20260824-124458.mp4
Testing criteria: