docs: flag the stale testnet deployment and inventory what it predates - #193
Open
chmm195 wants to merge 1 commit into
Open
docs: flag the stale testnet deployment and inventory what it predates#193chmm195 wants to merge 1 commit into
chmm195 wants to merge 1 commit into
Conversation
The contract IDs in the 'Deployed on Stellar testnet' table were deployed on 2026-07-05 and read as the current state of what is live. Around three dozen commits have landed against contracts/ since, so anyone testing against those IDs is exercising July code. Add a warning callout above the table and a grouped inventory of the behaviour-changing differences beneath it. The access-control gap is called out first: the deployed initialize performs no require_auth(), so on those IDs a third party can still be named admin on the first call (MergeFi#30). Also covers crowdfunding (MergeFi#57, MergeFi#58), the O(n log n) dust distribution (MergeFi#55), the adversarial-ordering tie-breaker (MergeFi#25) and the proportional TTL scaling (MergeFi#56). Documents the gap rather than redeploying, per the second option in MergeFi#110. Closes MergeFi#110
|
@chmm195 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110.
The issue offered two options — redeploy and refresh the IDs, or document the staleness. This takes the second: I have no key for the
GBUXADZJ...admin account, so redeploying would produce contract IDs nobody else can administer.What I checked
The table was added in
8a7efbf(2026-07-05).git log 8a7efbf..HEAD -- contracts/is ~36 commits, so the drift is wider than the four issues named in #110:initializerequires admin auth, all three contracts (#30)compute_split(#25)extend_deadline(#30 refund analysis)keep_alive(#56)The access-control one seems worth leading with, and #110 does not mention it: the deployed
initializeperforms norequire_auth()at all. Its only guard ishas(&DataKey::Admin), which blocks re-initialization but not the first call — so on those three contract IDs today, anyone can still name a third-party address as admin. Anybody poking at the testnet deployment should know that before they point anything real at it.The change
README only, two hunks:
> [!WARNING]callout above the table, with the deploy date and a link down to the detail#### What the deployed WASM predatessection beneath it, grouped into access control / fund flow / split math / TTL, each with its issue referenceAlso changed "deployed and initialized on testnet as of this writing" to name the actual date, since "as of this writing" is what let the section read as current for six weeks.
I deliberately left the contract IDs in place rather than removing them — they are still the real deployment, and the redeploy instructions right below are unchanged.
Happy to swap the callout for a plain paragraph if
[!WARNING]is heavier than you want, or to trim the inventory down to just the four issues from #110.