fix(memos-local-openclaw): normalize Windows paths when resolving better-sqlite3#1265
Open
hijzy wants to merge 1 commit intoMemTensor:openclaw-local-plugin-20260317from
Open
Conversation
…ter-sqlite3 Use fileURLToPath(import.meta.url) instead of new URL().pathname for correct platform path handling, and normalize both plugin dir and resolved module path before comparison to avoid false negatives on Windows where backslash vs forward-slash formats differ. Fixes MemTensor#1192
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1192.
On Windows, the plugin incorrectly reported
better-sqlite3 resolved outside plugin dirbecause of path format mismatches (C:\Users\...vsC:/Users/...).Changes:
fileURLToPath(import.meta.url)instead ofnew URL().pathnamenormalizeFsPath()to normalize both paths before comparison\vs/, case sensitivity, and relative/absolute path differences