Fix Windows sqlite path check and Gemini embedding defaults#1239
Open
buzuweidao wants to merge 1 commit intoMemTensor:openclaw-local-plugin-20260317from
Open
Fix Windows sqlite path check and Gemini embedding defaults#1239buzuweidao wants to merge 1 commit intoMemTensor:openclaw-local-plugin-20260317from
buzuweidao wants to merge 1 commit intoMemTensor:openclaw-local-plugin-20260317from
Conversation
Collaborator
|
Thanks for the fix! Two separate improvements here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues we hit while testing
apps/memos-local-openclawon Windows with Gemini:Windows path handling for
better-sqlite3path.dirname(new URL(import.meta.url).pathname)produced/C:/...on Windows.require.resolve()returnedC:\..., so the plugin incorrectly concludedbetter-sqlite3was outside the plugin directory and failed to load.fileURLToPath(import.meta.url)and normalized both paths before comparison.Gemini embedding defaults / compatibility
text-embedding-004togemini-embedding-001.v1/...:embedContentstyle values to the currentv1beta/...:batchEmbedContentsstyle.Validation
PUPPETEER_SKIP_DOWNLOAD=1 npm installnpm run buildgemini-embedding-001.Notes
The published package we tested also exposed a Viewer-side Gemini test issue, but that code path does not appear in the current repo source tree under
apps/memos-local-openclaw. This PR only includes the source changes I could trace and validate in the repository itself.