[persist] [wip] Task lease #34590
Draft
[persist] [wip] Task lease #34590
+414
−387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkirwi
force-pushed
the
task-lease
branch
4 times, most recently
from
d73f2b3 to
bfa3eba
Compare
This is somewhere between Tokio's `watch` and a normal mutex with a condvar. Kind of annoying to have to write one's own library for this, but everything else I tried was either awkward or needed an unbounded channel...
These two are much more tightly related than the task is to the read handle, and this allows for some additional privacy for shared state.
Observe new seqnos in both the handle and the heartbeat thread Always downgrade to the shared seqno Should be pretty recent! Use the main downgrade-since method in the background thread Do all downgrades in the background task Shift expiry to the background task Move the heartbeat task to read.rs This is a bit more read-handle business than machine business, in my opinion! Comment fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.