Skip to content

feat: add release please and push workflow#8

Merged
netanelC merged 25 commits into
masterfrom
add-release-please
May 7, 2026
Merged

feat: add release please and push workflow#8
netanelC merged 25 commits into
masterfrom
add-release-please

Conversation

@netanelC
Copy link
Copy Markdown
Contributor

Closes: #4

@netanelC netanelC self-assigned this Apr 27, 2026
@netanelC netanelC changed the base branch from master to add-commitlint April 27, 2026 08:34
Copy link
Copy Markdown

@ronenkapelian ronenkapelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to have:

add to readme:

Required GitHub Secrets

The following secrets must be configured in repository settings:

  • ACR_URL - Azure Container Registry URL (e.g., myregistry.azurecr.io)
  • ACR_PUSH_USER - Username/service principal for ACR
  • ACR_PUSH_TOKEN - Password/token for ACR authentication

How Releases Work

  1. Commit Changes: Use conventional commits (e.g., feat(scaler): add feature)
  2. Merge to Master: Release-please creates/updates a release PR
  3. Merge Release PR: Triggers Docker image build and push
  4. Automatic Tagging: Images are tagged with version and `latest

Consider adding caching to the building process:

  • name: Build and Push Docker Image
    uses: docker/build-push-action@v7
    with:
    context: ./${{ matrix.path }}
    push: true
    tags: '...'
    cache-from: type=registry,ref=${{ secrets.ACR_URL }}/${{ env.TEAM }}/${{ matrix.path }}:buildcache
    cache-to: type=registry,ref=${{ secrets.ACR_URL }}/${{ env.TEAM }}/${{ matrix.path }}:buildcache,mode=max

Ofer added something similar to opa-la mono-repo

Comment thread .release-please-manifest.json Outdated
Comment thread release-please-config.json Outdated
Base automatically changed from add-commitlint to master April 29, 2026 07:31
ronenkapelian
ronenkapelian previously approved these changes May 5, 2026
@netanelC netanelC merged commit 8e528ff into master May 7, 2026
2 checks passed
@netanelC netanelC deleted the add-release-please branch May 7, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unified CI/CD Release Pipeline (release-please)

2 participants