feat: add app#69
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Helm umbrella chart (charts/app) to this repository and wires it into the release-please workflow so it can be versioned/released alongside existing charts.
Changes:
- Register
charts/appinrelease-please-config.jsonand.release-please-manifest.json. - Add new
charts/appHelm chart metadata (Chart.yaml) and initialCHANGELOG.md. - Provide initial umbrella chart defaults in
charts/app/values.yamlfor the included subcharts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| release-please-config.json | Adds charts/app as a releasable helm package. |
| .release-please-manifest.json | Adds initial version entry for charts/app. |
| charts/app/Chart.yaml | Defines the app umbrella chart and its dependencies/conditions. |
| charts/app/values.yaml | Adds default configuration values for the umbrella chart and subcharts. |
| charts/app/CHANGELOG.md | Introduces initial changelog entry for the new chart. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
I can't approve these values since you are using helm-common and we already discussed that this is making your chart much messier.
I think Shimon as the tech lead should put its feet here @shimoncohen
No description provided.