feat: add raster-serving umbrella chart for helm Template migration(MAPCO-10333) by roicohen326 · Pull Request #59 · MapColonies/helm-charts-new

roicohen326 · 2026-03-26T14:36:03Z

Raster Serving - Elm Template Migration (Phase 1)

Migrates the raster-serving umbrella chart from the legacy helm Umbrella architecture (helm-charts) to the new helm Template (Helmfile) architecture.

What's included

Chart.yaml — Umbrella chart with all 5 dependencies pointing to OCI registry, using <subchart>.enabled condition pattern (matching core-stack, cloudnative-postgres conventions)
values.yaml — Base defaults (static/logic values only). Environment-specific values (OPA URLs, hostnames, TLS certs, extraVolumes, redis password) are stripped and belong in site-values

Sub-charts

Sub-chart	Version	Purpose
pycsw	6.4.1	Public catalog CSW endpoint
pycsw-private	6.4.1	Private catalog CSW endpoint
mapproxy	1.9.2	WMS/WMTS tile proxy
pp-geoserver	3.0.0	Polygon parts GeoServer
redis	18.5.0	MapProxy caching backend

Values marked with `# FLAG`

Values marked with # FLAG are kept in base defaults but may need review — they could potentially be environment-specific (resource limits, timeouts, polling intervals, log levels). Keeping them per the "unsure policy" until Team Lead review.

Copilot

Pull request overview

Adds new umbrella Helm charts for Raster services as part of the Helm Template (Helmfile) migration, including base default values.yaml and Chart.yaml dependency definitions.

Changes:

Introduces raster-serving umbrella chart with 5 dependencies and default values for pycsw/pycsw-private/mapproxy/pp-geoserver/redis.
Introduces raster-ingestion umbrella chart with dependency wiring and default values for ingestion components.
Introduces raster-export umbrella chart with dependency wiring and default values for export components.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
charts/raster-serving/Chart.yaml	New umbrella chart definition and dependency list for raster serving stack.
charts/raster-serving/values.yaml	Base default values passed into serving subcharts.
charts/raster-ingestion/Chart.yaml	New umbrella chart definition and dependency list for raster ingestion stack.
charts/raster-ingestion/values.yaml	Base default values passed into ingestion subcharts.
charts/raster-export/Chart.yaml	New umbrella chart definition and dependency list for raster export stack.
charts/raster-export/values.yaml	Base default values passed into export subcharts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-13T08:27:45Z

@@ -0,0 +1,34 @@
+apiVersion: v2
+name: serving


Chart name ('serving') doesn’t match the chart directory ('raster-serving'). In this repo chart names consistently match their directory (e.g., charts/core-stack/Chart.yaml:2, charts/openshift-routes/Chart.yaml:2). Consider renaming to 'raster-serving' to avoid collisions and keep packaging/release naming consistent.

Suggested change

name: serving

name: raster-serving

Copilot · 2026-04-13T08:27:45Z

@@ -0,0 +1,48 @@
+apiVersion: v2
+name: ingestion


Chart name ('ingestion') doesn’t match the chart directory ('raster-ingestion'). Other charts in this repo use the directory name as the chart name (e.g., charts/core-stack/Chart.yaml:2). Aligning these avoids confusion and potential name collisions when publishing/consuming charts.

Suggested change

name: ingestion

name: raster-ingestion

Copilot · 2026-04-13T08:27:45Z

@@ -0,0 +1,40 @@
+apiVersion: v2
+name: export


Chart name ('export') doesn’t match the chart directory ('raster-export'). The repository convention is that chart names match their folder (e.g., charts/tempo/Chart.yaml:2). Consider renaming to 'raster-export' to keep chart identity consistent.

Suggested change

name: export

name: raster-export

Copilot · 2026-04-13T08:27:46Z

+    repository: oci://acrarolibotnonprod.azurecr.io/helm
+
+  - name: tiles-splitter
+    version: 1.3.7
+    condition: tiles-splitter.enabled
+    repository: oci://acrarolibotnonprod.azurecr.io/helm
+
+  - name: cache-seeder
+    version: 2.1.2
+    condition: cache-seeder.enabled
+    repository: oci://acrarolibotnonprod.azurecr.io/helm


These dependencies use an OCI repository URL without a domain segment (oci://.../helm). Elsewhere in this repo OCI repos are always namespaced (e.g., oci://.../helm/common, oci://.../helm/infra). If the charts are actually published under a namespaced repo (likely '/helm/raster'), Helm dependency resolution will fail.

Suggested change

repository: oci://acrarolibotnonprod.azurecr.io/helm

- name: tiles-splitter

version: 1.3.7

condition: tiles-splitter.enabled

repository: oci://acrarolibotnonprod.azurecr.io/helm

- name: cache-seeder

version: 2.1.2

condition: cache-seeder.enabled

repository: oci://acrarolibotnonprod.azurecr.io/helm

repository: oci://acrarolibotnonprod.azurecr.io/helm/raster

- name: tiles-splitter

version: 1.3.7

condition: tiles-splitter.enabled

repository: oci://acrarolibotnonprod.azurecr.io/helm/raster

- name: cache-seeder

version: 2.1.2

condition: cache-seeder.enabled

repository: oci://acrarolibotnonprod.azurecr.io/helm/raster

Copilot · 2026-04-13T08:27:46Z

+  - name: exporter-cleanup
+    version: 3.0.0
+    condition: exporter-cleanup.enabled
+    repository: oci://acrarolibotnonprod.azurecr.io/helm


This dependency uses an OCI repository URL without a namespace segment (oci://.../helm). Other charts in this repo reference namespaced OCI repos (e.g., oci://.../helm/common or /helm/infra). If exporter-cleanup is published under a namespaced repo, Helm won’t be able to fetch it from this URL.

Suggested change

repository: oci://acrarolibotnonprod.azurecr.io/helm

repository: oci://acrarolibotnonprod.azurecr.io/helm/raster

Copilot · 2026-04-13T08:27:47Z

+  uwsgiExporter:
+    image:
+      repository: "timonwong/uwsgi-exporter"
+      tag: "latest"


The uwsgi-exporter image tag is set to 'latest'. Pin to a specific version/digest to avoid pulling different images over time.

Suggested change

tag: "latest"

tag: "v1.0.0"

Copilot · 2026-04-13T08:27:47Z

+    image:
+      repository: "timonwong/uwsgi-exporter"
+      tag: "latest"
+      imagePullPolicy: IfNotPresent


In the 'pycsw-private' section, uwsgiExporter sets imagePullPolicy under uwsgiExporter.image, while the 'pycsw' section uses uwsgiExporter.imagePullPolicy at the uwsgiExporter level. Since both use the same pycsw chart, one of these schemas is likely wrong and will be ignored. Align both to the pycsw chart’s expected values structure so pull policy is applied consistently.

Suggested change

imagePullPolicy: IfNotPresent

imagePullPolicy: IfNotPresent

Copilot · 2026-04-13T08:27:47Z

+  uwsgiExporter:
+    image:
+      repository: "timonwong/uwsgi-exporter"
+      tag: "latest"


The uwsgi-exporter image tag is set to 'latest'. Pin this to a specific version/digest so deployments are reproducible and don’t change unexpectedly when the upstream tag moves.

Suggested change

tag: "latest"

tag: "v1.0.0"

Copilot · 2026-04-13T08:27:48Z

+      tls:
+        enabled: true
+        useCerts: true
+#ask nati


Inline note '#ask nati' isn’t actionable/traceable. Prefer removing it or converting it to a TODO with context (e.g., link to a ticket/issue or a clear explanation of what decision is pending) so it doesn’t get stranded in defaults.

Suggested change

#ask nati

# TODO: Confirm whether this deployment should use the ingress configuration below

# instead of, or in addition to, the route configuration above before enabling it.

Copilot · 2026-04-13T08:27:48Z

+  - name: redis
+    version: 18.5.0
+    condition: redis.enabled
+    repository: https://charts.bitnami.com/bitnami


PR description says the umbrella chart dependencies point to the OCI registry, but redis is still sourced from the Bitnami HTTP repo here. If the intent is to fully migrate dependencies to OCI, redis should be pushed to ACR and referenced via an oci:// URL (or update the PR description to reflect that redis remains external).

… defaults

…v1.0.0

michalby24

As this umbrella chart that will be deployed using the site-values, there is no need to put the resources values here, put the defaults in the chart and if you need to override it use the site-values repo.
This apply to all resources in this PR
Avoid using pull policy always
Avoid using tag latest

michalby24 · 2026-04-20T06:35:15Z

@@ -0,0 +1,38 @@
+apiVersion: v2
+name: core


The chart directory should match the chart name, it is required by our CI and consistent with infra charts.
Apply to all charts in this PR (core, export, serving, ingestion)

michalby24 · 2026-04-20T06:44:46Z

+  image:
+    repository: raster/job-tracker
+    tag: "v5.0.0"
+    pullPolicy: Always


Why? IfNotPresent is our standard. Apply to all pullPolicy: Always in this PR

…values)

feat: add raster-serving umbrella chart for Elm Template migration

56012d1

roicohen326 changed the title ~~feat: add raster-serving umbrella chart for Elm Template migration~~ feat: add raster-serving umbrella chart for helm Template migration Mar 31, 2026

feat: add raster-export and raster-ingestion umbrella charts

3313a7d

roicohen326 changed the title ~~feat: add raster-serving umbrella chart for helm Template migration~~ feat: add raster-serving umbrella chart for helm Template migration(MAPCO-10333) Apr 2, 2026

Roi Cohen and others added 2 commits April 5, 2026 23:44

fix: rename chart names

da3306d

fix: remove upstream default values from raster umbrella charts

fa9afd6

Copilot AI review requested due to automatic review settings April 13, 2026 08:22

Copilot started reviewing on behalf of roicohen326 April 13, 2026 08:22 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

roicohen326 added 2 commits April 14, 2026 16:15

cleanup raster values - remove ingress, fix key mismatches, normalize…

29257e8

… defaults

feat: add raster-core umbrella chart and bump all raster services to …

d5107a0

…v1.0.0

michalby24 reviewed Apr 20, 2026

View reviewed changes

roicohen326 and others added 2 commits April 28, 2026 20:04

chore: strip infra values from raster umbrella charts (moved to site-…

776c4bb

…values)

fix: disable files-server and nginx-s3-gateway in raster-export

91caf06

	repository: oci://acrarolibotnonprod.azurecr.io/helm
	repository: oci://acrarolibotnonprod.azurecr.io/helm/raster

	#ask nati
	# TODO: Confirm whether this deployment should use the ingress configuration below
	# instead of, or in addition to, the route configuration above before enabling it.

Conversation

roicohen326 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Raster Serving - Elm Template Migration (Phase 1)

What's included

Sub-charts

Values marked with # FLAG

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

michalby24 left a comment

Choose a reason for hiding this comment

Uh oh!

michalby24 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

michalby24 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roicohen326 commented Mar 26, 2026 •

edited

Loading

Values marked with `# FLAG`