You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
from a technical standpoint, add validation rejecting negative radius values via a custom deserializer like opacity_deserializer.
Add [appearance.radius] to the example config in docs/src/core/config-system.md (pre-existing).
[appearance.radius]
sm = 4.0
md = 8.0
lg = 16.0
xl = 32.0
also @MalpenZibo stylisitc question
Field-level #[serde(default)] could be used instead of struct-level. Struct-level #[serde(default)] is fine and more concise, but the rest of Appearance uses field-level attrs (e.g. pub menu: MenuAppearance relies on MenuAppearance's own Default). Either style is acceptable here since Radius has a Default impl
Yes, I need to work on this since the last release. I had to decide the right direction. I prefer to work on this stuff personally, so I'm not sure if I will merge this PR. For sure, I will take this into consideration when defining the new option that I plan to add.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to expose the radius options to config, personally I prefer no rounded corners