Skip to content

Stall Guard for Gripper - #68

Merged
chosterto merged 8 commits into
mainfrom
feature/hand
Aug 20, 2026
Merged

Stall Guard for Gripper#68
chosterto merged 8 commits into
mainfrom
feature/hand

Conversation

@chosterto

Copy link
Copy Markdown
Member

No description provided.

Comment thread curie_ws/src/curie_arm_controller/gripper_control/gripper_stall_guard.cpp Outdated
Comment thread curie_ws/src/curie_arm_controller/package.xml Outdated
Comment thread curie_ws/src/curie_arm_controller/CMakeLists.txt
Comment thread curie_ws/src/warehouse_ros_mongo Outdated
Comment thread curie_ws/src/curie_hw_control/lib/spark_mmrt
@chosterto

chosterto commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@LfovS9 One last favor, could you add a log right before initializing the arm hardware that shows whether virtual CAN is enabled? Just so that errors on bringup are less ambiguous

    bool use_vcan_interface;
    std::string use_vcan_hw_param = info_.hardware_parameters["use_vcan"];
    std::transform(use_vcan_hw_param.begin(), use_vcan_hw_param.end(), use_vcan_hw_param.begin(), ::tolower);
    std::istringstream(use_vcan_hw_param) >> std::boolalpha >> use_vcan_interface;
    // TODO: Add log here...
    if (arm_hardware_.initialize(&use_vcan_interface) < 0)
    {
        return hardware_interface::CallbackReturn::ERROR;
    }
...

In addition, you could also add another error code for arm_controller (right now all errors are -1), one to indicate a CAN error when attempting to open the CAN transport, and the other a device read error

Comment thread curie_ws/src/curie_hw_control/interfaces/spark_arm_hardware.cpp
Comment thread curie_ws/src/curie_arm_controller/hardware/arm_controller.cpp Outdated

@chosterto chosterto left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@chosterto
chosterto merged commit cd634be into main Aug 20, 2026
@chosterto
chosterto deleted the feature/hand branch August 20, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants