Stall Guard for Gripper - #68
Merged
Merged
Conversation
chosterto
commented
Jul 18, 2026
Member
Author
|
@LfovS9 One last favor, could you add a log right before initializing the arm hardware that shows whether virtual CAN is enabled? Just so that errors on bringup are less ambiguous bool use_vcan_interface;
std::string use_vcan_hw_param = info_.hardware_parameters["use_vcan"];
std::transform(use_vcan_hw_param.begin(), use_vcan_hw_param.end(), use_vcan_hw_param.begin(), ::tolower);
std::istringstream(use_vcan_hw_param) >> std::boolalpha >> use_vcan_interface;
// TODO: Add log here...
if (arm_hardware_.initialize(&use_vcan_interface) < 0)
{
return hardware_interface::CallbackReturn::ERROR;
}
...In addition, you could also add another error code for |
chosterto
commented
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.