Skip to content

[DOP-39630] Hide secrets while logging settings value - #516

Merged
dolfinus merged 1 commit into
developfrom
improvement/DOP-39630
Aug 11, 2026
Merged

[DOP-39630] Hide secrets while logging settings value#516
dolfinus merged 1 commit into
developfrom
improvement/DOP-39630

Conversation

@dolfinus

@dolfinus dolfinus commented Aug 11, 2026

Copy link
Copy Markdown
Member

Change Summary

Discovered in MTSWebServices/horizon#227

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • mddocs/docs/changelog/next_release/<pull request or issue id>.<change type>.md file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus
dolfinus force-pushed the improvement/DOP-39630 branch from 1bff055 to e97bb75 Compare August 11, 2026 10:53
@dolfinus dolfinus changed the title Improvement/dop 39630 [DOP-39630] Hide secrets while logging settings value Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissBranchBrPartCoverMissing
data_rentgen/consumer
   __init__.py84218572%47->50, 50–54, 56, 61->74, 102, 129–132, 134, 136–140, 143->146, 159–162
data_rentgen/db
   settings.py2774271%16->17, 17–18, 21->22, 22–23, 72, 75–76
data_rentgen/http2kafka
   __init__.py53172265%37–42, 44, 46–50, 54, 99–102
data_rentgen/server
   __init__.py3040087%57–60
data_rentgen/server/providers/auth
   dummy_provider.py5966189%71–73, 91->92, 92–93, 109
   keycloak_provider.py1011314386%65, 79–82, 103->104, 104, 109->110, 110–111, 143–145, 163->164, 164–165
   personal_token_provider.py105922391%34->35, 35, 116–118, 131->132, 132–133, 137->138, 138–140
data_rentgen/server/settings/auth
   __init__.py1632178%43->44, 44–45, 50
TOTAL7600499127620792% 

@dolfinus
dolfinus marked this pull request as ready for review August 11, 2026 10:57
@dolfinus
dolfinus force-pushed the improvement/DOP-39630 branch 2 times, most recently from b3538fb to 0d2ad51 Compare August 11, 2026 13:09
@dolfinus
dolfinus force-pushed the improvement/DOP-39630 branch from 0d2ad51 to e4b5557 Compare August 11, 2026 13:14
@dolfinus
dolfinus merged commit a7bb52d into develop Aug 11, 2026
11 checks passed
@dolfinus
dolfinus deleted the improvement/DOP-39630 branch August 11, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants