Repository navigation
test: refresh the rai golden and compare it in full - #155
Open
renato-umeton wants to merge 1 commit into
Open
renato-umeton wants to merge 1 commit into
renato-umeton wants to merge 1 commit into
Conversation
The RAI test compared eight keys against the golden, so the rest of the file stopped matching what the tool bakes. Two output changes never reached it: RAI runs declare the RAI spec in conformsTo (#69), and compressed CSV files now also declare text/csv, ahead of application/gzip (#117). The file order also came from an older scan, so the text diff is large while the content change is small. The new test bakes the same command in both discovery orders and compares the whole document through the normaliser the other goldens use. The key check stays. The golden is regenerated with the CLI and the arguments the test passes.
This was referenced Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@slobentanzer the rai golden (tests/data/output/mimiciv_demo_croissant_rai.jsonld) was only checked on 8 rai/prov keys so the rest drifted from what we bake now..
what drifted:
(feat: add discovery and access fields with a Bioschemas profile #128 and fix: refuse unknown RAI config keys and correct the social impact key in the template #134 already hand patched the @id and rai:dataCollectionType bits)
what the test does now:
no timestamps or abs paths in the output so it's stable, also passes on 3.10 and 3.12 and w/ shuffled discovery. pls take a look, thx!