Repository navigation
Recommend Test-Driven Development in guidelines - #144
Merged
Merged
Conversation
Updated contribution guidelines to recommend Test-Driven Development in this file per @rafiattrach request in PR MIT-LCP#133
The reviewer of MIT-LCP#133 asked for two things: the advice belongs in CONTRIBUTING.md under Testing guidelines, which is what a first-time contributor opens, and it should say something the existing "add tests" bullet does not. Writing the failing test first is the concrete part, so it is now the first bullet of that list, and the workflow step goes back to its original wording.
rafiattrach
self-requested a review
September 26, 2026 07:52
rafiattrach
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated contribution guidelines to recommend Test-Driven Development in this file per @rafiattrach request in PR #133