Repository navigation
Bump croissant to v5.3.0.dev3: pole regression fixed, confirmed against Raul - #14
Merged
Merged
Conversation
Moves the pin from v5.3.0.dev2 to v5.3.0.dev3.
Prepared by croissant's scripts/bump_consumers.py; this passed
against the new pin:
uv run --all-extras pytest -q tests/test_beam.py tests/test_horizon.py tests/test_map.py tests/test_rotation_investigation.py tests/test_sim.py tests/test_sky.py
Run the comparison under the v5.3.0.dev3 pin as a third environment. The North Pole disagreement with Raul drops from 117.527 K under PR 12 to 0.873 K, and the MARS tests shift slightly (1.303 -> 1.297 K and 0.921 -> 0.899 K). PR 12 and v5.3.0.dev3 differ only in croissant, whose package source changed only in rotations.py, the fix for croissant#152, so the recovery is attributable to that fix. Label each environment by the croissant git ref its pin requested. The eq2cirs check would have labelled v5.3.0.dev3 as PR 12. The two recorded environments keep their labels through KNOWN_LABELS. List runs in chronological order rather than filename order. Rewrite cell 0 and the results cell for three environments, and lift the warning against regenerating the southpole synthetic data: the rotation error at that site is 0.000 degrees under v5.3.0.dev3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012qDDdFg7x9CVkj4EGVT8AE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the croissant pin to v5.3.0.dev3, which contains the fix for the pole regression reported in christianhbye/croissant#152 (fixed by christianhbye/croissant#153). It also adds that environment to the Raul comparison notebook as a third run.
Impact: the North Pole regression that #12 introduced is fixed, and is confirmed against Raul's reference simulator. Mean |mistsim − Raul| and the arch ratio (mid-day residual over edge residual):
uv.lockchanges nothing except croissant-sim. Between v5.3.0.dev2 and v5.3.0.dev3, croissant's package source changed only insrc/croissant/rotations.py, which is the #152 fix. So the North Pole recovery (117.527 K → 0.873 K) and the small MARS shifts come from that fix.mainvs Move onto croissant v5.3.0.dev2 and its s2fft fork; put sky alm in the Earth frame of date #12 can't be pinned on one cause the same way, because those environments also differ in s2fft and jax.southpolesite'sruns.yamlstart time and latitude −90, the error in croissant's reconstructed rotation is 1.4° under 5.1.4, 38.5° under v5.3.0.dev2 and 0.000° under v5.3.0.dev3. The warning against regeneratingdata/synthetic_data/southpole-*.npzis lifted.Changes
pyproject.toml,uv.lock: croissant pin moves fromv5.3.0.dev2tov5.3.0.dev3(commita3e4f42, prepared by croissant'sscripts/bump_consumers.py). The s2fft fork pin and jax are unchanged.notebooks/sim_comparisons/raul_comparison.ipynb:hasattr(cro.rotations, "eq2cirs")check would have labelled v5.3.0.dev3 as "PR 12". The two environments already recorded keep their labels.Verification
uv run pytest: 111 passed on the bump commit.5.2.1+git58bf56e); the other two environments load from cache. No cell errors, anddata/beam.npzanddata/feko_beam.npzwere not modified.ee3aca5). They follow the same pattern as the 5.1.4 kernel setup, which was tested.🤖 Generated with Claude Code
https://claude.ai/code/session_012qDDdFg7x9CVkj4EGVT8AE