Security: Fix hardcoded credentials and sensitive data exposure#170
Open
saaa99999999 wants to merge 1 commit into
Open
Security: Fix hardcoded credentials and sensitive data exposure#170saaa99999999 wants to merge 1 commit into
saaa99999999 wants to merge 1 commit into
Conversation
Remove hardcoded JWT signing key defaults, default admin password, database credentials, prometheus basic auth, and JWT token logging. CWE-798: Hardcoded JWT keys and credentials in config defaults CWE-532: JWT access token logged in plaintext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple security issues related to hardcoded credentials and sensitive data exposure.
1. Hardcoded JWT Signing Key (CWE-798)
pkg/jwtx/jwt.go:22— Removed hardcoded default keyCG24SDVP8OHPK395GB5Ginternal/config/middleware.go:39— Removed default signing keyXnEsT0S@configs/dev/middleware.toml:31— Replaced hardcoded key with empty placeholderinternal/wirex/injector.go:91-92— Added startup validation: application will fail to start if signing key is not configured2. Default Admin Password (CWE-798)
internal/config/config.go:26— Removed default password hashMD5(abc-123)with comment that revealed the actual password3. JWT Token Leaked in Logs (CWE-532)
internal/mods/rbac/biz/login.biz.go:134— Removed full JWT token from log output, preventing token theft from logs4. Default Prometheus Credentials (CWE-1392)
internal/config/config.go:101-102— Removed default admin/admin credentials5. Dev Environment Hardcoded Passwords (CWE-798)
.devcontainer/.env:4-5— Replaced hardcoded PostgreSQL password with placeholderTest plan