Repository navigation
fix: stop the patch flow from crashing when new-boot.img is missing - #223
Merged
Merged
Conversation
boot_patch.sh now saves the `kptools -i kernel -f` output and status, prints a non-zero probe on stderr and exits with that status, and exits 1 when the probe succeeds without CONFIG_KALLSYMS=y. The patch-only branch exits 1 with "- new-boot.img missing" when the file is absent, and the flash branch flashes only when the boot path is a block or character device and new-boot.img is present, exiting 1 with "- new-boot.img missing - refusing to flash" when the file is absent. In PATCH_ONLY, PatchesViewModel logs " Patch failed." and returns if new-boot.img is missing or the copy throws IOException. scripts/test_boot_patch_output.py drives those script outcomes with a stub kptools, and the contracts workflow's Boot patch output job runs it. Refs LyraVoid#201
Contributor
Author
|
@matsuzaka-yuki thanks for taking this one. The patch flow shouldn't crash anymore when new-boot.img is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boot_patch.sh now saves the
kptools -i kernel -foutput and status, prints a non-zero probe on stderr and exits with that status, and exits 1 when the probe succeeds without CONFIG_KALLSYMS=y. A patch-only run crashes in the manager with FileNotFoundException while opening new-boot.img when that file was never written.The :app:testClasses Gradle run failed at configuration because computed versionCode 113232 is not greater than managerVersionFloor=115036.
Refs #201