Skip to content

Notes on sorting: Lexicographic vs Natural - #4590

Merged
ildyria merged 1 commit into
masterfrom
notes-sorting
Aug 5, 2026
Merged

Notes on sorting: Lexicographic vs Natural#4590
ildyria merged 1 commit into
masterfrom
notes-sorting

Conversation

@ildyria

@ildyria ildyria commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation
    • Added detailed Gallery sorting guidance explaining natural and lexicographical ordering.
    • Documented how sorting affects pagination and provided recommendations for consistent photo naming.
    • Added or updated localized guidance across all supported languages.
  • Settings
    • Gallery settings now include a clear description of available sorting behaviors and their recommended use cases.

@ildyria
ildyria requested a review from a team as a code owner August 5, 2026 21:46
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The change adds reversible Gallery sorting guidance through a Laravel migration and replaces empty Gallery descriptions with localized explanations across 23 language files.

Changes

Gallery sorting guidance

Layer / File(s) Summary
Persist Gallery description
database/migrations/2026_08_05_000000_add_sorting_description.php
The migration adds HTML-formatted guidance for natural and lexicographical sorting. Its rollback clears the description.
Localize Gallery description
lang/*/all_settings.php
Localized Gallery descriptions explain sorting behavior, pagination effects, ordering examples, and filename padding recommendations.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Poem

A rabbit reads the Gallery sign,
“Sort names well, and pages align.”
Natural numbers hop in place,
Lexical order sets the pace.
Each language now explains the race.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d5da6167-5e3e-4e31-a110-31c513faafda

📥 Commits

Reviewing files that changed from the base of the PR and between a6f45c0 and 1468bc3.

📒 Files selected for processing (24)
  • database/migrations/2026_08_05_000000_add_sorting_description.php
  • lang/ar/all_settings.php
  • lang/bg/all_settings.php
  • lang/cz/all_settings.php
  • lang/de/all_settings.php
  • lang/el/all_settings.php
  • lang/en/all_settings.php
  • lang/es/all_settings.php
  • lang/fa/all_settings.php
  • lang/fr/all_settings.php
  • lang/hu/all_settings.php
  • lang/it/all_settings.php
  • lang/ja/all_settings.php
  • lang/nl/all_settings.php
  • lang/no/all_settings.php
  • lang/pl/all_settings.php
  • lang/pt/all_settings.php
  • lang/ru/all_settings.php
  • lang/sk/all_settings.php
  • lang/sv/all_settings.php
  • lang/tr/all_settings.php
  • lang/vi/all_settings.php
  • lang/zh_CN/all_settings.php
  • lang/zh_TW/all_settings.php

Comment thread database/migrations/2026_08_05_000000_add_sorting_description.php
Comment thread lang/fr/all_settings.php
@ildyria
ildyria merged commit e8aba62 into master Aug 5, 2026
50 checks passed
@ildyria
ildyria deleted the notes-sorting branch August 5, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant