Repository navigation
chore: bump wrangler to 4.156.0 - #28
Merged
Merged
Conversation
Wrangler 4.134.0 builds the version preview URL from the account-level
workers.dev subdomain (GET /accounts/{id}/workers/subdomain), which
needs account-wide Workers Scripts Read. The Worker-scoped deploy token
can't read it, so branch preview uploads failed with 10000 after the
version had already uploaded. Since 4.136.1 Wrangler reads the preview
URL suffix from the Worker's own subdomain endpoint instead
(cloudflare/workers-sdk#15678).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the branch deploy failure in #27: `Upload Preview` failed with `Authentication error [code: 10000]` on `/accounts/***/workers/subdomain`.
Wrangler 4.134.0 uploads the preview version first, then calls the account-level `GET /workers/subdomain` just to print the "Version Preview URL" line. That endpoint needs account-wide `Workers Scripts Read`, which the Worker-scoped `cloudflare-development` token doesn't have. Since 4.136.1 (cloudflare/workers-sdk#15678), Wrangler reads `preview_url_suffix` from the Worker's own `GET /workers/scripts/skycrypt-embed/subdomain` instead, which the token can already read.
The lockfile changes are Wrangler's own tree (workerd, miniflare, unenv-preset, sharp). esbuild dedupes to the 0.28.2 already in use, and `@cloudflare/workers-types` drops out of drizzle-orm's peer suffix because Wrangler no longer lists it as a peer. Nothing in the repo imports it.
This branch's own `Deploy Workers` run is the check: `Upload Preview` should pass and print the preview URLs. Once this is on `dev`, #27 needs `dev` merged in.
🤖 Generated with Claude Code