Repository navigation
Fix release test failures (scan-token race, layout test on small screens) - #727
Merged
Merged
Conversation
LineVisibilityTracker read the scan's cancellation token inside the queued task; disposing or restarting before the task started faulted it with ObjectDisposedException. Read the token under the lock instead. HighlightDialogLayoutTests assumed the scaled minimum size fits the screen; Windows caps forms at the screen size, so 1.5x/2x failed on the 1024x768 CI runner. Treat that case as inconclusive. Name groupBoxSelection so overlap messages identify it.
Hirogen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.50.0 release build (run 37122052131) failed in the Test target: