Repository navigation
Fix/test isolation - #724
Merged
Merged
Conversation
added 3 commits
October 3, 2026 11:59
JSONSaveTest and the portable-mode tests saved, created, moved and deleted files in %APPDATA%\LogExpert through ConfigManager.Instance, overwriting the developer's settings.json with test data on every full run. ConfigDir now has an internal setter, and an assembly-wide SetUpFixture points it at a temporary directory before any test runs. A guard test fails if the tests ever see the real directory again.
MenuToolbarController and LedIndicatorService decided whether to marshal by comparing the current SynchronizationContext with the one captured at construction. On the UI thread under a different context instance they re-posted to themselves forever; under NUnit's context their callbacks ran on other threads and set form icons cross-thread, which later left a Log Window's teardown blocked in SetWindowRgn. They now compare thread ids. UI tests that open a Log Tab Window install the WinForms synchronization context the app runs with, cross-thread control access fails the test instead of deadlocking, and a 3-minute VSTest hang timeout for every test project ends a hung run with a dump and the test name.
PluginValidator reads and creates trusted-plugins.json in %APPDATA%\LogExpert until Initialize is called, which only the app does; every test assembly that loads plugins rewrote the developer's real file. Each of them now points it at a temporary directory before any test runs, and the isolation guard test also checks the plugin trust path.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix UI test hangs and keep tests out of the user's configuration