Repository navigation
fix: confirm a verified /rename with a visible message - #23
Merged
Merged
Conversation
A rename turn used to end with only a session_info_update. Lody treats a turn without visible output as a failure (agent_no_output) even though the title had changed. After the verified title notification the adapter now sends one fixed agent_message_chunk, `Session renamed to "<name>".`, using the name read back from OMP, and only then completes the prompt. Nothing is sent when verification fails or the control is cancelled before commit. A failed confirmation send fails the prompt like any other notification failure; the already applied name is not rolled back. Records the decision in docs-ai/020 and revises 015, whose "no synthesized assistant" wording this overrides. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
真实 Lody 验收里,
/rename <标题>会把标题改掉,但界面同时报agent_no_output:这一轮只发了session_info_update,Lody 不把它算作可见输出。/rename核实成功、explicit 标题通知发出之后,适配器再发一条固定的agent_message_chunk:Session renamed to "<读回的 sessionName>".,然后才end_turn。文案沿用 OMP 原生的改名提示。README.md里的「不合成 assistant」,依据是 2026-11-16 的裁决。决策记在docs-ai/020-rename-confirmation/,015 加了修订004-rename-confirmation.md。证据
src/之前有 13 项断言失败,原因都是缺确认文字;实现后npm run check423 项通过,npm run build通过。end_turn依次出现,改名期间 0 个模型请求。/rename,不再报错。docs-ai/020-rename-confirmation/001-action.md。不在本 PR 内
TESTING.md的 Required cases 没有改动。npm run contract和发布矩阵。COMPATIBILITY.md里通过的行仍是d6362de上的证据,发布提交上要重跑。RELEASE.md的复选框,不打 tag、不发布、不改 Lody manifest。Test plan
npm run check(423 项)npm run build