Skip to content

fix: confirm a verified /rename with a visible message - #23

Merged
dustPyrotechnic merged 1 commit into
mainfrom
fix/rename-confirmation
Nov 16, 2026
Merged

dustPyrotechnic merged 1 commit into
mainfrom
fix/rename-confirmation

Conversation

@dustPyrotechnic

Copy link
Copy Markdown
Collaborator

概要

真实 Lody 验收里,/rename <标题> 会把标题改掉,但界面同时报 agent_no_output:这一轮只发了 session_info_update,Lody 不把它算作可见输出。

  • 显式 /rename 核实成功、explicit 标题通知发出之后,适配器再发一条固定的 agent_message_chunk:Session renamed to "<读回的 sessionName>".,然后才 end_turn。文案沿用 OMP 原生的改名提示。
  • 核实失败或提交前取消时不发。确认文字发送失败按既有的通知失败处理:关闭连接、prompt 失败,不回滚已经改掉的名称。
  • 确认文字不是模型输出,不计用量,也不写进 OMP 会话文件。
  • 这覆盖了 015 和 README.md 里的「不合成 assistant」,依据是 2026-11-16 的裁决。决策记在 docs-ai/020-rename-confirmation/,015 加了修订 004-rename-confirmation.md。

证据

  • 测试先行:改 src/ 之前有 13 项断言失败,原因都是缺确认文字;实现后 npm run check 423 项通过,npm run build 通过。
  • 隔离 profile 加本地回环模型,对真实 OMP 18.20.2 和 18.20.1 实测:标题通知、确认文字、end_turn 依次出现,改名期间 0 个模型请求。
  • Lody 开发构建里重发 /rename,不再报错。
  • 计划经两轮独立核对后允许实现。实现经两轮独立审核,代码和测试没有发现问题;三条文档类发现已修正,其中 IR20-003 的措辞修正没有再审,见 docs-ai/020-rename-confirmation/001-action.md。

不在本 PR 内

  • 不改 Lody,不改能力宣告。
  • TESTING.md 的 Required cases 没有改动。
  • 没有重跑 npm run contract 和发布矩阵。COMPATIBILITY.md 里通过的行仍是 d6362de 上的证据,发布提交上要重跑。
  • 不勾选 RELEASE.md 的复选框,不打 tag、不发布、不改 Lody manifest。

Test plan

  • npm run check(423 项)
  • npm run build
  • 真实 OMP 18.20.2 和 18.20.1 的隔离探针
  • CI

A rename turn used to end with only a session_info_update. Lody treats a
turn without visible output as a failure (agent_no_output) even though the
title had changed. After the verified title notification the adapter now
sends one fixed agent_message_chunk, `Session renamed to "<name>".`, using
the name read back from OMP, and only then completes the prompt.

Nothing is sent when verification fails or the control is cancelled before
commit. A failed confirmation send fails the prompt like any other
notification failure; the already applied name is not rolled back.

Records the decision in docs-ai/020 and revises 015, whose "no synthesized
assistant" wording this overrides.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@dustPyrotechnic
dustPyrotechnic merged commit 6892c0c into main Nov 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant