Skip to content

Conversation

@andygrundman
Copy link
Contributor

Description

macOS scroll wheel handling now correctly translates the 120-per-click into "1 line" of Mac scroll, which seems safer than using pixels. We should confirm that the direction of hscroll is correct here. I was going to try to add tests for this, but test_mouse is a mess, doesn't have any scroll wheel tests, and is not even enabled on Windows or Linux.

I also threw in a fix for a compile error with the latest Xcode.

Screenshot

Issues Fixed or Closed

Fixes #3103
Fixes #3711

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@andygrundman andygrundman changed the title Fix handling of vertical and horizontal mouse wheel scroll events. (#3103, #3711) fix(macos/input): Fix handling of vertical and horizontal mouse wheel scroll events. (#3103, #3711) Jan 17, 2026
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher ReenigneArcher changed the title fix(macos/input): Fix handling of vertical and horizontal mouse wheel scroll events. (#3103, #3711) fix(macos/input): Fix handling of mouse wheel scroll events Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.46%. Comparing base (ab52e27) to head (f1c9cb9).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4592      +/-   ##
==========================================
- Coverage   15.52%   15.46%   -0.06%     
==========================================
  Files          94       94              
  Lines       19025    19025              
  Branches     8772     8772              
==========================================
- Hits         2953     2942      -11     
- Misses      14934    14948      +14     
+ Partials     1138     1135       -3     
Flag Coverage Δ
Archlinux 11.54% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.81% <ø> (ø)
Homebrew-ubuntu-22.04 13.82% <ø> (ø)
Linux-AppImage 11.85% <ø> (ø)
Windows-AMD64 13.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 25 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit b0bf510 into LizardByte:master Jan 17, 2026
52 of 53 checks passed
@codecov
Copy link

codecov bot commented Jan 17, 2026

Bundle Report

Bundle size has no change ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is an issue with the scrolling function in macOS No scrolling in MacOS

2 participants