wasmtime - asyncify & signal interruption#349
Closed
qianxichen233 wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
|
This is failing some tests, do we think its related to this PR: #350 Also need to fix for linter |
rennergade
reviewed
Aug 20, 2025
| arg6, | ||
| ), | ||
| _ => { | ||
| // if we are reaching here at rewind state, that means fork is called within |
Contributor
There was a problem hiding this comment.
This comment could be a bit more verbose, im not sure whats going on here exactly
rennergade
reviewed
Aug 20, 2025
| arg6, | ||
| ); | ||
|
|
||
| // Assumption: lind_syscall_api will not switch asyncify state, which holds true for now |
Contributor
There was a problem hiding this comment.
if we have an assumption like this we need to explain why its true
rennergade
requested changes
Aug 20, 2025
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
a little more commenting would help, also a better PR description
rennergade
changed the title
Yaxuan-w
requested changes
Aug 27, 2025
Member
Yaxuan-w
left a comment
Yaxuan-w
left a comment
There was a problem hiding this comment.
Would be great to have a more descriptive description, which explains why we need this modification
| signal_asyncify_data: Vec<SignalAsyncifyData>, | ||
| signal_asyncify_counter: u64, | ||
| // syscall asyncify data, holds the sequence of syscall return value | ||
| syscall_asyncify_data: Vec<i32>, |
Member
There was a problem hiding this comment.
Maybe naming as sth like sys_return_async would be clearer?
| assert_eq!(tank.get_fuel(), 0); | ||
| } | ||
| } | ||
| } No newline at end of file |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is splited from PR #164
This PR focuses on spliting out the signal interruption implementation on wasmtime part. Added logic to have Asyncify supporting signal interruption on syscall