[LM-12339] Real Time#85
Open
jaixchaudhary wants to merge 1 commit intomasterfrom
Open
Conversation
ishaan1607
suggested changes
Feb 17, 2025
| console.log("WebSocket connection opened."); | ||
| }, | ||
| onMessageReceived: async (data) => { | ||
| console.log("New message received:", data.conversation); |
Comment on lines
+648
to
+658
| const conversationID = data?.conversation?.id; | ||
| if (conversationID) { | ||
| const maxTimeStamp = Math.floor(Date.now() * 1000); | ||
| await firebaseConversationSyncAPI( | ||
| INITIAL_SYNC_PAGE, | ||
| 0, | ||
| maxTimeStamp, | ||
| conversationID | ||
| ); | ||
| fetchChatroomDetails(); | ||
| } |
Contributor
There was a problem hiding this comment.
why are we calling API? when we are getting whole conversation object in data
| }); | ||
| }, [chatroomID]); | ||
|
|
||
| const ChatCallback = { |
Contributor
There was a problem hiding this comment.
please match the variable name from ed.
| console.log("WebSocket connection closed."); | ||
| }, | ||
| onError: (errorMessage: string) => { | ||
| console.error("WebSocket error:", errorMessage); |
Contributor
There was a problem hiding this comment.
Show the error as toast message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Features
What kind of change does this PR introduce? (check at least one)
Author Checklist
Reviewer Checklist