fix(schedule): correct date display and layout issues #916
+10
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced the specific dates display with a text string using the `schedule_daily` format. - Removed unused CSS to improve maintainability. - Added a CSS class to the date removal icon to indicate it is clickable. - Prevented duplicate loading of `moment.js`. - Removed an unnecessary line break that caused grid misalignment relative to the filter.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects date display formatting and improves code maintainability in the schedule module. The changes replace technical date formats with user-friendly formatted dates, remove duplicate script loading, improve layout alignment, and clean up unused CSS.
Changes:
- Replaced raw date format (YYYY-MM-DD) with user-formatted dates using the
schedule_dailyformat - Removed duplicate loading of moment.js (already loaded via javascript-includes.tpl)
- Fixed grid alignment by removing an extraneous line break
- Cleaned up commented-out CSS and removed unused styles
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tpl/Schedule/schedule.tpl | Added wrapper div for datepicker alignment, removed duplicate moment.js loading, added altFormatDate config, changed DatePickerSetupControl parameter |
| tpl/Schedule/schedule-reservations-grid.tpl | Removed line break that caused grid misalignment |
| Web/scripts/schedule.js | Added date formatting using flatpickr to display user-friendly dates instead of ISO format |
| Web/css/schedule.css | Removed commented CSS code, added cursor style for date removal icon, removed unused reservationsToTop styles |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnVillalovos
approved these changes
Jan 19, 2026
Contributor
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @labmecanicatec
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schedule_dailyformat.moment.js.