Fix eta calculation - #166
Open
8nt0n wants to merge 7 commits into
Open
Conversation
- Exclude 'ok', 'fail', 'aborted', and 'stopped' files from remaining ETA byte count - Remove unused t_start variable and clarify ETA smoothing window comments - Add test_snapshot_eta_ignores_terminal_states test case
Remove unused variable t_start from eta calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85
Description
This PR resolves multiple accuracy, stability, and edge-case issues in the ETA calculation logic (
moon_engine.pyandapp.js):raw_eta >= 7200to returnNone(instead of the7200sentinel), allowingapp.jsto properly render--.file_bytesfor in-flight files and applying average estimates only to pending files without known sizes.ok,fail,aborted,stopped) from_trackedso failed or aborted partial downloads no longer contribute ghost remaining bytes to the ETA.t_start), updated window comments, and added unit tests intest_snapshot_speed.pycovering clamp behavior and terminal-state handling.Type of change
Checklist
moon_cli.py