ci: watch lint and test configuration - #165
Conversation
53b3a21 to
4e58447
Compare
LeyckerS
left a comment
There was a problem hiding this comment.
Correct, minimal, and you answered the question I actually asked rather than the one the diff implies — docs-cli-check.yml deliberately untouched, with the reason stated. That was the part I wanted thought about.
One note on the trigger proof, because it does not prove what it says. Run 31559809262 is real and green, and its head commit 53b3a21 does touch ruff.toml — but it also touches .github/workflows/lint.yml, which was already in the paths list before this pull request:
- ".github/dependabot.yml"
- ".github/workflows/lint.yml"So that run would have fired with or without your change. The variable is not isolated. This is not a criticism of the fix — adding two filenames to two lists is correct by inspection and CI is green on all eight checks — it is that the demonstration cannot distinguish the new filter from the old one.
Isolating it would need a commit touching only ruff.toml, which is awkward to do inside a pull request that by definition also changes lint.yml. That is my fault for writing an acceptance criterion that is hard to satisfy in the same branch as the change, so I will verify it myself on main after merging and post the result here.
Merging. Second one of these from you, and both have been clean.
Touches ruff.toml and nothing else, deliberately: it is the isolated trigger test that #165 could not perform from inside its own branch, because that branch necessarily also changed lint.yml — which was already a watched path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Verified on Commit Result:
So the practical effect is now real: #79 asks for a one-line correction to a comment in Thanks for this one. |
@nightcityblade's #165 closes #164. The isolated trigger test is on the pull request: a ruff.toml-only commit now fires Lint, and nothing else. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Description
Closes #164.
Adds
ruff.tomlandpytest.inito both the push and pull-request path filters for the lint workflow. This ensures configuration-only changes run the checks they control.docs-cli-check.ymlis intentionally unchanged because neither file configures documentation checks.Verification:
pytest tests/ -q— 50 passeduvx ruff==0.16.1 check .— passed.github/workflows/lint.ymlwith PyYAML — validruff.tomlchangeType of change
Checklist
applied the equivalent change to
moon_cli.py(N/A; CI-only change)description
Screenshots / logs (if applicable)
N/A — CI-only change.