Skip to content

ci: watch lint and test configuration - #165

Merged
LeyckerS merged 1 commit into
LeyckerS:mainfrom
nightcityblade:fix/issue-164
Aug 12, 2026
Merged

ci: watch lint and test configuration#165
LeyckerS merged 1 commit into
LeyckerS:mainfrom
nightcityblade:fix/issue-164

Conversation

@nightcityblade

@nightcityblade nightcityblade commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #164.

Adds ruff.toml and pytest.ini to both the push and pull-request path filters for the lint workflow. This ensures configuration-only changes run the checks they control. docs-cli-check.yml is intentionally unchanged because neither file configures documentation checks.

Verification:

  • pytest tests/ -q — 50 passed
  • uvx ruff==0.16.1 check . — passed
  • Parsed .github/workflows/lint.yml with PyYAML — valid
  • CI trigger proof: run 31559809262, fired for the initial commit's temporary comment-only ruff.toml change

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would change existing behavior)
  • Documentation update
  • Refactor / code cleanup
  • Other:

Checklist

  • I have tested my changes locally
  • If this affects shared logic (extraction, download engine), I also
    applied the equivalent change to moon_cli.py (N/A; CI-only change)
  • I have kept the single-file architecture (no package split)
  • I have not added new dependencies without justification in the PR
    description

Screenshots / logs (if applicable)

N/A — CI-only change.

@LeyckerS LeyckerS left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, minimal, and you answered the question I actually asked rather than the one the diff implies — docs-cli-check.yml deliberately untouched, with the reason stated. That was the part I wanted thought about.

One note on the trigger proof, because it does not prove what it says. Run 31559809262 is real and green, and its head commit 53b3a21 does touch ruff.toml — but it also touches .github/workflows/lint.yml, which was already in the paths list before this pull request:

      - ".github/dependabot.yml"
      - ".github/workflows/lint.yml"

So that run would have fired with or without your change. The variable is not isolated. This is not a criticism of the fix — adding two filenames to two lists is correct by inspection and CI is green on all eight checks — it is that the demonstration cannot distinguish the new filter from the old one.

Isolating it would need a commit touching only ruff.toml, which is awkward to do inside a pull request that by definition also changes lint.yml. That is my fault for writing an acceptance criterion that is hard to satisfy in the same branch as the change, so I will verify it myself on main after merging and post the result here.

Merging. Second one of these from you, and both have been clean.

@LeyckerS
LeyckerS merged commit e60dabe into LeyckerS:main Aug 12, 2026
8 checks passed
LeyckerS added a commit that referenced this pull request Aug 12, 2026
Touches ruff.toml and nothing else, deliberately: it is the isolated
trigger test that #165 could not perform from inside its own branch,
because that branch necessarily also changed lint.yml — which was
already a watched path.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@LeyckerS

Copy link
Copy Markdown
Owner

Verified on main, as promised.

Commit 3194603 touches ruff.toml and nothing else — I checked the commit's file list rather than trusting my own staging:

files changed: ruff.toml

Result:

Lint: completed/success   ← https://github.com/LeyckerS/moondownloader/actions/runs/31641873825

Lint fired, and only Lint. Docs CLI Check correctly stayed out of it, since it watches **.md and **.py and neither matched. That is the isolated proof your branch could not produce, and it confirms the filter does what the diff says.

So the practical effect is now real: #79 asks for a one-line correction to a comment in ruff.toml, and whoever takes it will get a CI run on their pull request instead of a blank check list. That was the reason the issue existed.

Thanks for this one.

LeyckerS added a commit that referenced this pull request Aug 12, 2026
@nightcityblade's #165 closes #164. The isolated trigger test is on the
pull request: a ruff.toml-only commit now fires Lint, and nothing else.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: the two files that control what CI checks are the two files CI does not watch

2 participants