Skip to content

Modernize the library - #64

Merged
IvanSanchez merged 9 commits into
gh-pagesfrom
modernize
May 26, 2026
Merged

Modernize the library#64
IvanSanchez merged 9 commits into
gh-pagesfrom
modernize

Conversation

@mourner

@mourner mourner commented May 25, 2026

Copy link
Copy Markdown
Member

A warning in Leaflet that this dev dep has some security issue has been bugging me, so I made a quick maintenance pass:

  • Drop build step: switch to type: module ESM; remove Rollup/Buble and dist/.
  • Drop deps: replace xregexp with native \p{ID_*} regex, minimist with node:util parseArgs, jasmine with node:test + node:assert/strict.
  • ESLint 10 flat config (eslint.config.js); varlet/const, .hasOwnPropertyObject.hasOwn, misc lint fixes
  • CI: GitHub Actions running npm ci + npm test on Node 24.

@mourner

mourner commented May 25, 2026

Copy link
Copy Markdown
Member Author

cc @IvanSanchez for your 👀

@IvanSanchez IvanSanchez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mourner Running npm install; npm run test locally fails with:

node:internal/test_runner/harness:99
      throw err;
      ^

TypeError: Missing internal module 'internal/deps/brace-expansion'
    at requireBuiltin (node:internal/bootstrap/realm:429:19)
    at requireWithFallbackInDeps (node:internal/bootstrap/realm:441:10)
    at node:internal/deps/minimatch/index:7:43
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
    at requireBuiltin (node:internal/bootstrap/realm:430:14)
    at lazyMinimatch (node:internal/fs/glob:45:17)
    at createMatcher (node:internal/fs/glob:111:15)
    at node:internal/fs/glob:298:62
    at Array.map (<anonymous>)
    at new Glob (node:internal/fs/glob:298:21)

@IvanSanchez

Copy link
Copy Markdown
Member

Running npm install; npm run test locally fails with

Nevermind; updating nodejs from v22 to v24 fixes that issue.

Comment thread src/regexps.js Outdated
Comment thread package.json
@mourner

mourner commented May 26, 2026

Copy link
Copy Markdown
Member Author

@IvanSanchez OK fixed, should work on Node v18+ now.

@IvanSanchez

Copy link
Copy Markdown
Member

@mourner 👍

@IvanSanchez
IvanSanchez merged commit 9003bbd into gh-pages May 26, 2026
1 check passed
@mourner

mourner commented May 27, 2026

Copy link
Copy Markdown
Member Author

@IvanSanchez nice! Can you please do a release with this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants