Modernize the library - #64
Merged
Merged
Conversation
Member
Author
|
cc @IvanSanchez for your 👀 |
IvanSanchez
requested changes
May 26, 2026
IvanSanchez
left a comment
Member
There was a problem hiding this comment.
@mourner Running npm install; npm run test locally fails with:
node:internal/test_runner/harness:99
throw err;
^
TypeError: Missing internal module 'internal/deps/brace-expansion'
at requireBuiltin (node:internal/bootstrap/realm:429:19)
at requireWithFallbackInDeps (node:internal/bootstrap/realm:441:10)
at node:internal/deps/minimatch/index:7:43
at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
at requireBuiltin (node:internal/bootstrap/realm:430:14)
at lazyMinimatch (node:internal/fs/glob:45:17)
at createMatcher (node:internal/fs/glob:111:15)
at node:internal/fs/glob:298:62
at Array.map (<anonymous>)
at new Glob (node:internal/fs/glob:298:21)
Member
Nevermind; updating nodejs from v22 to v24 fixes that issue. |
IvanSanchez
requested changes
May 26, 2026
Member
Author
|
@IvanSanchez OK fixed, should work on Node v18+ now. |
Member
|
@mourner 👍 |
Member
Author
|
@IvanSanchez nice! Can you please do a release with this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A warning in Leaflet that this dev dep has some security issue has been bugging me, so I made a quick maintenance pass:
type: moduleESM; remove Rollup/Buble anddist/.xregexpwith native\p{ID_*}regex,minimistwithnode:utilparseArgs,jasminewithnode:test+node:assert/strict.eslint.config.js);var→let/const,.hasOwnProperty→Object.hasOwn, misc lint fixesnpm ci+npm teston Node 24.