feat: allow using int and string on ids#5752
Open
Chemaclass wants to merge 3 commits intoLaravel-Backpack:mainfrom
Open
feat: allow using int and string on ids#5752Chemaclass wants to merge 3 commits intoLaravel-Backpack:mainfrom
Chemaclass wants to merge 3 commits intoLaravel-Backpack:mainfrom
Conversation
Member
|
Hello @Chemaclass Thanks for the PR will be checked by our team and if everything is ok will be merged soon. Thanks again. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Follow up after Chemaclass@c50874e
uuid/ulid are string based not int
AFTER - What is happening after this PR?
The id will support int and string
HOW
How did you achieve that, in technical terms?
Updating the PHPDoc
Is it a breaking change?
Nope
How can we test the before & after?
Everything should work as before.