Under the Sea Quest Line Fixes - #11447
Open
KiplingFFXI wants to merge 1 commit into
Open
Conversation
Xaver-DaRed
reviewed
Sep 12, 2026
| return Event.perform(self, playerArg, npcArg) | ||
| end | ||
|
|
||
| return event |
Contributor
There was a problem hiding this comment.
explain what you are doing here and why it must be this way
Contributor
Author
There was a problem hiding this comment.
In the cap, the quest NPC gives the rod and takes the shall shell before the event starts. I added this to match retail's timing but also prevent duplicate rewards from being issued if the player disconnects immediately upon turning in the items.
I have simplified the handler to achieve the same results, is this better? If not let me know and I can change it, thanks.
KiplingFFXI
force-pushed
the
Under-the-Sea-Capture-Fixes
branch
from
September 12, 2026 13:46
12c982c to
24d36e4
Compare
KiplingFFXI
force-pushed
the
Under-the-Sea-Capture-Fixes
branch
from
September 12, 2026 23:06
24d36e4 to
3ddbeab
Compare
Contributor
Author
|
rebased after key item PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR audits the quests Under the Sea and The Real Gift against retail captures. It updates reward timing and reward timing. Also, this PR removes the FISHING_ENABLE requirement from Under the Sea, The Gift, The Real Gift, and Inside the Belly. Fame and fishing skill requirements stay unchanged.
Steps to test these changes
Do the quest line. See even if fishing is turned off, you can still flag them. See that they still work as intended but the quest grants and reward timings now follow retail.
Captures
Siknoz
Quest - Other Areas - The Real Gift.zip
Quest - Others - Under the Sea.zip