fix: narrow solution for double free crash on destroy#623
Open
adsharma wants to merge 1 commit into
Open
Conversation
This is a hard to reproduce heisenbug. Suspected cause: two threads racing on database close/destroy + GC which does an implicit destroy. A full solution would have to use `std::atomic` on all pointer dereferences on conn and database. We may be already protected by the language runtimes against such races. The intent is to try the narrow solution first and then go for something more invasive only if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #452
This is a hard to reproduce Heisenbug. Suspected cause: two threads racing on database close/destroy + GC which does an implicit destroy.
A full solution would have to use
std::atomicon all pointer dereferences on conn and database. We may already be protected by the language runtimes against such races.The intent is to try the narrow solution first and then go for something more invasive only if necessary.