Skip to content

Fix/dashboard form accessibility#985

Open
Benedict315 wants to merge 2 commits into
LabsCrypt:mainfrom
Benedict315:fix/dashboard-form-accessibility
Open

Fix/dashboard form accessibility#985
Benedict315 wants to merge 2 commits into
LabsCrypt:mainfrom
Benedict315:fix/dashboard-form-accessibility

Conversation

@Benedict315

Copy link
Copy Markdown
Contributor

Description

Summary: Adds proper id attributes to all form inputs and htmlFor attributes to labels in the dashboard settings tab's stream-creation form for proper accessibility association.

Changes:

Added id attributes to all inputs, textarea, and select elements in the stream form
Added htmlFor attributes to all labels to programmatically associate them with their controls
Added a visually-hidden label for the template name input (previously only had aria-label)
Used consistent wrapping label pattern throughout the form
Files modified:

dashboard-view.tsx (lines 887, 922, 931-943)
Accessibility improvements:

Screen readers can now properly announce field labels
Controls can be targeted by tests and anchor links via their ids
Maintains existing visual appearance (no visual changes)
closes #632

@ogazboiz ogazboiz mentioned this pull request Jul 4, 2026
19 tasks
@ogazboiz

ogazboiz commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

the dashboard form a11y (label associations) + the rust test look fine, the only red is the auth-jwt tamper test, which comes from the broken auth.ts on your old base, your pr touches no auth code. rebase onto the current green main (which has correct jwt verification) and it'll clear: git fetch origin && git rebase origin/main && git push --force-with-lease. note this overlaps your #986, keep the a11y here and handle the jwt work there (its current version has an auth bug, see my review on it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Dashboard settings tab form: bare-string labels with no htmlFor association

3 participants