Fix: Add id and htmlFor attributes to stream create form fields for accessibility#971
Open
T-kesh wants to merge 2 commits into
Open
Fix: Add id and htmlFor attributes to stream create form fields for accessibility#971T-kesh wants to merge 2 commits into
T-kesh wants to merge 2 commits into
Conversation
…ccessibility - Add id='recipient' and htmlFor='recipient' to Recipient Address field - Add id='create-stream-token' and htmlFor='create-stream-token' to Token select - Add id='create-stream-amount' and htmlFor='create-stream-amount' to Total Amount field - Add id='create-stream-duration' and htmlFor='create-stream-duration' to Duration field Fixes LabsCrypt#631
Contributor
Author
|
@ogazboiz Should i go ahead with the fixes or just leave them for now? |
Contributor
|
heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #631 - Add accessibility attributes to stream create form fields
Changes
Added id="recipient" and htmlFor="recipient" to Recipient Address field
Added id="create-stream-token" and htmlFor="create-stream-token" to Token select
Added id="create-stream-amount" and htmlFor="create-stream-amount" to Total Amount field
Added id="create-stream-duration" and htmlFor="create-stream-duration" to Duration field
Why this matters The form labels in page.tsx were not properly associated with their form controls. Screen readers could not pair the labels with inputs/selects, making the form inaccessible to users relying on assistive technology.
Impact
No visual changes
Improves accessibility for screen reader users
Aligns with the modal Wizard which already has proper htmlFor attributes