Skip to content

Fix: Add id and htmlFor attributes to stream create form fields for accessibility#971

Open
T-kesh wants to merge 2 commits into
LabsCrypt:mainfrom
T-kesh:fix/stream-create-form-labels
Open

Fix: Add id and htmlFor attributes to stream create form fields for accessibility#971
T-kesh wants to merge 2 commits into
LabsCrypt:mainfrom
T-kesh:fix/stream-create-form-labels

Conversation

@T-kesh

@T-kesh T-kesh commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #631 - Add accessibility attributes to stream create form fields

Changes

Added id="recipient" and htmlFor="recipient" to Recipient Address field
Added id="create-stream-token" and htmlFor="create-stream-token" to Token select
Added id="create-stream-amount" and htmlFor="create-stream-amount" to Total Amount field
Added id="create-stream-duration" and htmlFor="create-stream-duration" to Duration field
Why this matters The form labels in page.tsx were not properly associated with their form controls. Screen readers could not pair the labels with inputs/selects, making the form inaccessible to users relying on assistive technology.

Impact

No visual changes
Improves accessibility for screen reader users
Aligns with the modal Wizard which already has proper htmlFor attributes

…ccessibility

- Add id='recipient' and htmlFor='recipient' to Recipient Address field
- Add id='create-stream-token' and htmlFor='create-stream-token' to Token select
- Add id='create-stream-amount' and htmlFor='create-stream-amount' to Total Amount field
- Add id='create-stream-duration' and htmlFor='create-stream-duration' to Duration field

Fixes LabsCrypt#631
@T-kesh

T-kesh commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@ogazboiz Should i go ahead with the fixes or just leave them for now?

@ogazboiz

ogazboiz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

heads up: main's ci was broken (the Backend CI and Backend Docker Image CI jobs) until the fixes in #969 and #974 just landed, so the red backend/docker checks on this pr are almost certainly stale, they ran against the broken main. please rebase to re-test against the now-green main: git fetch origin && git rebase origin/main && git push --force-with-lease. once it's green i'll review and merge. (if a non-backend check like Frontend CI is still red after the rebase, that part is a real issue worth a look, since frontend ci was passing on main.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Create Stream page form fields have no label/htmlFor (Recipient/Token/Amount/Duration)

2 participants