Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
[Infra] Guard lint-staged in .husky/pre-commit with fallback message (#1077)
Closes #1077
PR Description
📝 Summary
Updates
.husky/pre-committo include a local binary guard check forlint-staged. Iflint-stagedis not installed or executable innode_modules, it prints a user-friendly error message pointing tonpm installand exits cleanly with status1.❓ Why this matters
Fixes issue #1077. Previously,
.husky/pre-commitrannpx lint-stageddirectly without local installation checks. When a contributor's environment was offline or missingnode_modules,npxfailed with a cryptic error instead of instructing the developer to runnpm install.🛠 Changes
.husky/pre-commitwith ashshebang, guard comment, and executable check[ ! -x ./node_modules/.bin/lint-staged ].stderron failure.npxlookup latency by invoking local./node_modules/.bin/lint-stageddirectly.🧪 Verification
lint-stagedis missing (lint-staged is not installed locally. Run 'npm install' before committing.).lint-stagedwhen local dependencies are installed.