minor fix to support latest numpy - #469
Open
timedilatesme wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With numpy 2.5.1 I was experiencing issues but I see that in requirements.txt the numpy version is set to < 2.4.0 so perhaps this is not needed right now but flagging this here just in case. Will add a fallback for backwards compatibility with numpy < 2.4
This PR also makes the
sis_convention=Trueas the default option and allows the user to modify it if they want to via theGalaxyDeflectorsclass.Have also flagged that abundance matching needs to be updated such that it is pl-slope aware in addition to M* and sigma*