-
Notifications
You must be signed in to change notification settings - Fork 38
fix: teaching-contract formatting, box height cap, anchor highlighting + dry ref #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rdmueller
merged 6 commits into
LLM-Coding:main
from
raifdmueller:fix/teaching-contract-formatting
Jun 2, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a1ade04
fix: structure teaching-contract template + cap contract box height
raifdmueller 0d16e87
feat: highlight declared anchors inside contract text (display only)
raifdmueller e1a01e8
fix: correct dangling anchor ref in code-quality contract (dry-princi…
raifdmueller d7bbbab
feat: curated anchor aliases for broader in-text highlighting
raifdmueller 3779b70
fix: use i18n.currentLang() and make anchor fetch non-fatal (CodeRabbit)
raifdmueller 82ee5af
style: wrap Promise.allSettled callback to satisfy Prettier (100-col)
raifdmueller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die neue Render-Strecke bleibt dadurch effektiv EN-only.
highlightAnchors()ist hier nicht das Problem —renderContractCard()zieht den Text weiter übergetLocalizedField(), und der Helper liest in derselben Dateii18n.currentLanguage. In diesem Repo ist diese Propertyundefined, daher fallen die Karten immer auf EN zurück; die neu formatiertentemplateDe-Texte und auch der Copy/Download-Pfad inbuildContractsMarkdown()werden auf der Contracts-Seite nicht korrekt lokalisiert. Bitte den Sprachzugriff konsistent aufi18n.currentLang()umstellen.Based on learnings: In this repo’s i18n integration (
website/src/i18n.js), the active language must be read via the methodi18n.currentLang()rather than a property likei18n.currentLanguage.🤖 Prompt for AI Agents