bias voltage readback with software cache - #448
Merged
Conversation
- update tool to support fiberless in Bias menu again - make Bias no-copy so cache never needs to be copied
something print ???? when we are unsure on what the value is since we don't have readback abilities
Member
Author
|
See the wiki page on SiPM and LED Biases for more detail on the numbers that should be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ended up being a bit more involved than I expected since (a) we used to copy
Biasaround a lot andstd::arraydoes not copy its values around to save time (so I madeBiasno-copy) and (b) the bias menu of pftool was only for HcalBackplanes so I added an intermediateTargetwhich bothHcalBackplaneandHcalFiberlessinherit from and declares thebiasfunction .The software cache uses
std::optionalso that we can be transparent about when we do know that the channel has been set to some value and when we don't.