Skip to content

Fixed python formatting in LUT-related scripts to match ruff standards. - #2098

Merged
tvami merged 2 commits into
trunkfrom
iss2035-pythonformatting
Jul 21, 2026
Merged

Fixed python formatting in LUT-related scripts to match ruff standards.#2098
tvami merged 2 commits into
trunkfrom
iss2035-pythonformatting

Conversation

@cjbarton151

Copy link
Copy Markdown
Contributor

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Just a simple fix of a few files to satisfy the formatting requirements laid out by ruff.
After this, we can probably mark #2035 as closed and completed.

Check List

  • I successfully compiled ldmx-sw with my developments.
  • I read, understood and follow the coding rules.
  • I ran my developments and the following shows that they are successful.

All ruff checks passed. I ran the LUT generation sequence (runLUTeventgen.py, runLUTclusterstxt.py, runLUTana.py) in a test configuration, and the results were identical to doing the same on trunk.

@tvami
tvami merged commit cdf90d9 into trunk Jul 21, 2026
@tvami
tvami deleted the iss2035-pythonformatting branch July 21, 2026 14:47
@tvami

tvami commented Jul 21, 2026

Copy link
Copy Markdown
Member

Thanks a lot @cjbarton151 !

@github-actions

Copy link
Copy Markdown
Contributor

Validation Results

All validation samples passed! ✅

Sample Status
cascade_history ✅ PASS
deep_ecal_gun ✅ PASS
eat_signal ✅ PASS
ecal_pn ✅ PASS
hcal ✅ PASS
inclusive ✅ PASS
it_pileup ✅ PASS
kaon_enhanced ✅ PASS
reduced_ldmx ✅ PASS
signal ✅ PASS
signal_target_al ✅ PASS
target_genie ✅ PASS
target_pn_lyso ✅ PASS
target_ti_en ✅ PASS
wab_lhe ✅ PASS

cascade_history:

  • Text Differences Between Logs (2 lines differ)
  • Timing for cascade_history: gold=6217s, new=6194s
  • Timing within 0% of gold (tolerance 10%)

deep_ecal_gun:

  • Text Differences Between Logs (18 lines differ)
  • Timing regression for deep_ecal_gun: new=4213s vs gold=3763s (+11%, tolerance 10%)
  • Timing for deep_ecal_gun: gold=3763s, new=4213s

eat_signal:

  • Timing for eat_signal: gold=1618s, new=1617s
  • Timing within 0% of gold (tolerance 10%)

ecal_pn:

  • Text Differences Between Logs (28 lines differ)
  • Timing for ecal_pn: gold=6718s, new=6761s
  • Timing within 0% of gold (tolerance 10%)

hcal:

  • Text Differences Between Logs (2 lines differ)
  • Timing regression for hcal: new=769s vs gold=665s (+15%, tolerance 10%)
  • Timing for hcal: gold=665s, new=769s

inclusive:

  • Text Differences Between Logs (52 lines differ)
  • Timing regression for inclusive: new=6862s vs gold=3573s (+92%, tolerance 10%)
  • Timing for inclusive: gold=3573s, new=6862s

it_pileup:

  • Text Differences Between Logs (50 lines differ)
  • Timing anomaly for it_pileup: new=504s vs gold=599s (-15%, tolerance 10%)
  • Timing for it_pileup: gold=599s, new=504s

kaon_enhanced:

  • Text Differences Between Logs (24 lines differ)
  • Timing for kaon_enhanced: gold=3095s, new=3152s
  • Timing within 1% of gold (tolerance 10%)

reduced_ldmx:

  • Text Differences Between Logs (16 lines differ)
  • Timing for reduced_ldmx: gold=144s, new=143s
  • Timing within 0% of gold (tolerance 10%)

signal:

  • Text Differences Between Logs (32 lines differ)
  • Timing for signal: gold=1189s, new=1221s
  • Timing within 2% of gold (tolerance 10%)

signal_target_al:

  • Text Differences Between Logs (30 lines differ)
  • Timing for signal_target_al: gold=936s, new=961s
  • Timing within 2% of gold (tolerance 10%)

target_genie:

  • Text Differences Between Logs (232 lines differ)
  • Timing regression for target_genie: new=9865s vs gold=5707s (+72%, tolerance 10%)
  • Timing for target_genie: gold=5707s, new=9865s

target_pn_lyso:

  • Text Differences Between Logs (36 lines differ)
  • Timing for target_pn_lyso: gold=6341s, new=6396s
  • Timing within 0% of gold (tolerance 10%)

target_ti_en:

  • Text Differences Between Logs (34 lines differ)
  • Timing regression for target_ti_en: new=3174s vs gold=2738s (+15%, tolerance 10%)
  • Timing for target_ti_en: gold=2738s, new=3174s

wab_lhe:

  • Text Differences Between Logs (30 lines differ)
  • Timing for wab_lhe: gold=6754s, new=6752s
  • Timing within 0% of gold (tolerance 10%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants