Fix overlaps in the Al geometry

[tvami]

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #2088

Check List

• I successfully compiled ldmx-sw with my developments.
• I read, understood and follow the coding rules.

• I ran my developments and the following shows that they are successful.

Tagger + Target + Recoil envelops

Tagger + Target + Recoil real stuff

[github-actions]

Validation Results

Some validation samples failed! ❌

Sample	Status
cascade_history	✅ PASS
deep_ecal_gun	✅ PASS
eat_signal	✅ PASS
ecal_pn	✅ PASS
hcal	✅ PASS
inclusive	✅ PASS
it_pileup	✅ PASS
kaon_enhanced	✅ PASS
signal	✅ PASS
target_genie	✅ PASS
target_pn_lyso	✅ PASS
target_ti_en	✅ PASS
wab_lhe	✅ PASS
reduced_ldmx	❌ FAIL (117 histograms failed KS test) (artifact)
signal_target_al	❌ FAIL (1133 histograms failed KS test) (artifact)

reduced_ldmx:

• 117 plots failed the KS test against gold.
• Text Differences Between Logs (276845 lines differ)
• Log character count differs by 0% (gold=33428186, new=33305569); within tolerance
• Timing anomaly for reduced_ldmx: new=127s vs gold=211s (-39%, tolerance 10%)
• Timing for reduced_ldmx: gold=211s, new=127s

signal_target_al:

• 1133 plots failed the KS test against gold.
• Text Differences Between Logs (179672 lines differ)
• Log character count differs by 1%: gold=16793512, new=16496793
• Timing for signal_target_al: gold=1047s, new=941s
• Timing within 10% of gold (tolerance 10%)

cascade_history:

• Text Differences Between Logs (2 lines differ)
• Timing for cascade_history: gold=5968s, new=6265s
• Timing within 4% of gold (tolerance 10%)

deep_ecal_gun:

• Text Differences Between Logs (22 lines differ)
• Timing for deep_ecal_gun: gold=4091s, new=4033s
• Timing within 1% of gold (tolerance 10%)

eat_signal:

• Timing for eat_signal: gold=1602s, new=1616s
• Timing within 0% of gold (tolerance 10%)

ecal_pn:

• Text Differences Between Logs (50 lines differ)
• Timing anomaly for ecal_pn: new=5096s vs gold=6232s (-18%, tolerance 10%)
• Timing for ecal_pn: gold=6232s, new=5096s

hcal:

• Text Differences Between Logs (2 lines differ)
• Timing anomaly for hcal: new=698s vs gold=829s (-15%, tolerance 10%)
• Timing for hcal: gold=829s, new=698s

inclusive:

• Text Differences Between Logs (36 lines differ)
• Timing for inclusive: gold=6805s, new=6716s
• Timing within 1% of gold (tolerance 10%)

it_pileup:

• Text Differences Between Logs (46 lines differ)
• Timing for it_pileup: gold=577s, new=592s
• Timing within 2% of gold (tolerance 10%)

kaon_enhanced:

• Text Differences Between Logs (20 lines differ)
• Timing for kaon_enhanced: gold=3122s, new=3091s
• Timing within 0% of gold (tolerance 10%)

signal:

• Text Differences Between Logs (18 lines differ)
• Timing for signal: gold=1184s, new=1189s
• Timing within 0% of gold (tolerance 10%)

target_genie:

• Text Differences Between Logs (4480 lines differ)
• Timing for target_genie: gold=6488s, new=6565s
• Timing within 1% of gold (tolerance 10%)

target_pn_lyso:

• Text Differences Between Logs (36 lines differ)
• Timing for target_pn_lyso: gold=6455s, new=6344s
• Timing within 1% of gold (tolerance 10%)

target_ti_en:

• Text Differences Between Logs (36 lines differ)
• Timing for target_ti_en: gold=3226s, new=3162s
• Timing within 1% of gold (tolerance 10%)

wab_lhe:

• Text Differences Between Logs (32 lines differ)
• Timing for wab_lhe: gold=6770s, new=6645s
• Timing within 1% of gold (tolerance 10%)

[tvami]

Tracking is back! yay!

Still quite a lot of zero track events, which I guess is about the high theta nature of the signal

[bloodyyugo]

A lot of the failing plots look like they aren't filled correctly, even basic ones...eg. RecoilDQM_p.pdf:

RecoilDQM_p.pdf

..not sure what's going on here.

[tvami]

That's because of the overlay with gold. Gold didn't have the correct spectrum so in the same zoom if we add the new branch it's not visible. If you look at the 2D plots like p vs the pull, you can see the new branch fills the momentum quite nicely.

[bloodyyugo]

Ah, ok. So All good then? If you are happy, I am happy.

[tvami]

Yes, I'm happy, please sign it!

I've run with 1000 events, here is the p distribution: