Skip to content

Move Al Signal CI to use Al based LHE - #2086

Merged
tvami merged 1 commit into
trunkfrom
iss2085-al-signal-lhe
Jun 18, 2026
Merged

Move Al Signal CI to use Al based LHE#2086
tvami merged 1 commit into
trunkfrom
iss2085-al-signal-lhe

Conversation

@tvami

@tvami tvami commented Jun 18, 2026

Copy link
Copy Markdown
Member

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #2085
with LDMX-Software/ci-data@a9b7104

Check List

  • I successfully compiled ldmx-sw with my developments.
  • I read, understood and follow the coding rules.
  • I ran my developments and the following shows that they are successful.

@github-actions

Copy link
Copy Markdown
Contributor

Validation Results

Some validation samples failed! ❌

Sample Status
cascade_history ✅ PASS
deep_ecal_gun ✅ PASS
eat_signal ✅ PASS
ecal_pn ✅ PASS
hcal ✅ PASS
inclusive ✅ PASS
it_pileup ✅ PASS
kaon_enhanced ✅ PASS
reduced_ldmx ✅ PASS
signal ✅ PASS
target_genie ✅ PASS
target_pn_lyso ✅ PASS
target_ti_en ✅ PASS
wab_lhe ✅ PASS
signal_target_al ❌ FAIL (1085 histograms failed KS test) (artifact)

signal_target_al:

  • 1085 plots failed the KS test against gold.
  • Text Differences Between Logs (109104 lines differ)
  • Log character count differs by 0% (gold=16793512, new=16841890); within tolerance
  • Timing anomaly for signal_target_al: new=931s vs gold=1047s (-11%, tolerance 10%)
  • Timing for signal_target_al: gold=1047s, new=931s

cascade_history:

  • Text Differences Between Logs (2 lines differ)
  • Timing for cascade_history: gold=5968s, new=6058s
  • Timing within 1% of gold (tolerance 10%)

deep_ecal_gun:

  • Text Differences Between Logs (26 lines differ)
  • Timing for deep_ecal_gun: gold=4091s, new=4083s
  • Timing within 0% of gold (tolerance 10%)

eat_signal:

  • Timing for eat_signal: gold=1602s, new=1510s
  • Timing within 5% of gold (tolerance 10%)

ecal_pn:

  • Text Differences Between Logs (38 lines differ)
  • Timing for ecal_pn: gold=6232s, new=6689s
  • Timing within 7% of gold (tolerance 10%)

hcal:

  • Text Differences Between Logs (2 lines differ)
  • Timing for hcal: gold=829s, new=841s
  • Timing within 1% of gold (tolerance 10%)

inclusive:

  • Text Differences Between Logs (36 lines differ)
  • Timing for inclusive: gold=6805s, new=6750s
  • Timing within 0% of gold (tolerance 10%)

it_pileup:

  • Text Differences Between Logs (42 lines differ)
  • Timing for it_pileup: gold=577s, new=597s
  • Timing within 3% of gold (tolerance 10%)

kaon_enhanced:

  • Text Differences Between Logs (36 lines differ)
  • Log character count differs by 0% (gold=10113147, new=10113146); within tolerance
  • Timing for kaon_enhanced: gold=3122s, new=2962s
  • Timing within 5% of gold (tolerance 10%)

reduced_ldmx:

  • Text Differences Between Logs (20 lines differ)
  • Timing for reduced_ldmx: gold=211s, new=213s
  • Timing within 0% of gold (tolerance 10%)

signal:

  • Text Differences Between Logs (36 lines differ)
  • Timing for signal: gold=1184s, new=1237s
  • Timing within 4% of gold (tolerance 10%)

target_genie:

  • Text Differences Between Logs (4480 lines differ)
  • Timing for target_genie: gold=6488s, new=6635s
  • Timing within 2% of gold (tolerance 10%)

target_pn_lyso:

  • Text Differences Between Logs (42 lines differ)
  • Timing anomaly for target_pn_lyso: new=4847s vs gold=6455s (-24%, tolerance 10%)
  • Timing for target_pn_lyso: gold=6455s, new=4847s

target_ti_en:

  • Text Differences Between Logs (48 lines differ)
  • Timing anomaly for target_ti_en: new=2469s vs gold=3226s (-23%, tolerance 10%)
  • Timing for target_ti_en: gold=3226s, new=2469s

wab_lhe:

  • Text Differences Between Logs (28 lines differ)
  • Timing for wab_lhe: gold=6770s, new=6873s
  • Timing within 1% of gold (tolerance 10%)

@tvami
tvami requested a review from danyi211 June 18, 2026 15:00
@tvami

tvami commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

A LOT fails the KS test. Here is what I find relevant by eye as well.

pr2086_signal_target_al_recon_validation_plots.pdf

What I see here makes sense: much higher angles, higher pT, etc

I've completely omitted the Recoil tracking plots. I included the truth recoil that points out the situation. It really seems like CKF (with the current setting) cant do the angles this signal gives us, this is something we should investigate specifically @bloodyyugo

@tvami
tvami merged commit d8628d5 into trunk Jun 18, 2026
22 of 23 checks passed
@tvami
tvami deleted the iss2085-al-signal-lhe branch June 18, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the Al based LHE in the signal_target_al CI

3 participants