Feature/period and dpc#247
Conversation
… pairs frequency and power and finds peak power and peakindex. stores periodogram. moved foldperiod to be its own function. and applies selected period
Periodogram generates a dynamic phased curve based on the point that the user selects. Added styling as well.
Component stores values in store and reacts to user's selections. Currently, not sensitive enough to clicks.
…' into feature/period-and-dpc Merging Jon's base branch with my changes
Removes code related to phased light curve
Data was obtained through the store. Now it's through props. The phase curve is now dynamic. When user clicks on a point in the periodogram the phase curve updates its values Adds periodogram logic
Data is now passed through props instead of through the store. Logic to fold period and manage data is also here instead of in store.
The chart downloads as png and all items are black
jnation3406
changed the base branch from
main
to
feature/periodogram_improvements
jnation3406
left a comment
jnation3406
left a comment
There was a problem hiding this comment.
All the code looks good to me, just a few comments on styling to make it more tablet friendly and a more efficient use of space. Also, this was part of my branch so not your code, but we should style the output from the operation to be the same sized square on the OperationOutputGrid so it lines up better.
| <div | ||
| class="analysis-content" | ||
| > | ||
| <v-row class="analysis-row"> |
There was a problem hiding this comment.
I think we should have a v-if on if those structures exist to render these 3 rows of plots. i.e. only try to show a row of light curve if light curve data exists in props.data, etc.
| :periodogram-data="periodogramData" | ||
| class="period-plot" | ||
| /> | ||
| </v-row> |
There was a problem hiding this comment.
I think we should fill the space better. Maybe having a larger light curve on the left column, then a stacked periodogram / phased light curve on the right? Or a stacked light curve / periodogram on the left and larger phased light curve on the right? Or maybe a larger periodogram since that is the one the user is interacting with?
Either way, just think we can fill up the space a bit better, which might be important for a tablet to see all 3 plots on screen at once without scrolling down.
There was a problem hiding this comment.
there's no scrolling, but that just means that the graphs are small. I'll work on something
| </template> | ||
|
|
||
| <style scoped> | ||
| .wrapper { |
There was a problem hiding this comment.
All 3 of these *Plot.vue files share similar styling I think? So that's a sign that they could potentially re-use code, whether that be a re-used full component, or just a re-used stylesheet they import.
| ref="lightCurveCanvas" | ||
| class="light-curve-plot" | ||
| /> | ||
| <v-btn |
There was a problem hiding this comment.
For all three of these Plots, I would work the download button into the title line, at the end of the title. Like Periodogram <Download Icon Here>. That should be a more efficient use of space and allow us to make the plots take up more of the room, which will probably be important for tablet screens.
There was a problem hiding this comment.
alright, eaaaasy fix
|
@jnation3406 I'll address the styling suggestions on a separate PR |
| @@ -34,7 +34,7 @@ export const useAnalysisStore = defineStore('analysis', { | |||
| falseAlarmProbability: 0, // false alarm probability for the variable star | |||
There was a problem hiding this comment.
I think some of these variables relating to the variable star stuff should be no longer used and can be removed too.
2 participants
FEATURE: Dynamic phased light curve based on periodogram selection & download of charts
Background:
While the light curve was generated based on the highest peak of the periodogram, it's useful for users to select anywhere on the chart and have a light curve be generated based on their selection.
Implementations
Moved logic around, particularly logic from the Analysis store because this logic no longer belongs in the Analysis view. A lot of files updated was code removed.
When user clicks on a point on the line of the periodogram, the listener emits a value to the phased light curve component and it regenerates the chart based on the values passed.
UPDATE NOT CAPTURED ON VISUALS
Flipped values on magnitude in phased light curve chart
VISUALS
Screen recording of flow
Screen.Recording.2026-01-06.at.5.02.56.PM.mov
Downloaded charts (as pngs)
