Skip to content

fix(docs): externalize new padrone subpath entry points#17

Merged
KurtGokhan merged 1 commit into
mainfrom
claude/fix-docs-build-externals
May 10, 2026
Merged

fix(docs): externalize new padrone subpath entry points#17
KurtGokhan merged 1 commit into
mainfrom
claude/fix-docs-build-externals

Conversation

@KurtGokhan
Copy link
Copy Markdown
Owner

Summary

The Deploy Docs workflow on main broke after #15 (run). The docs build bundles @padrone/tasks-example, which now imports padrone/ink. Vite's resolve.external list in docs/astro.config.mts only had padrone and padrone/zod, so Rollup failed to resolve the new subpath:

[vite]: Rollup failed to resolve import "padrone/ink" from
"…/examples/padrone-example/src/tasks.ts".

Adding the new subpath entry points (padrone/ink, padrone/mcp, padrone/serve, padrone/tracing, padrone/completion, padrone/man) to the external list restores the build.

Test plan

  • Reproduced the failure locally with a clean docs build (no padrone/dist)
  • Confirmed bun run build from docs/ succeeds after the fix
  • No source/tests/typecheck changes — root bun run checks already green on main

Generated by Claude Code

The docs build pulls in `@padrone/tasks-example`, which now imports
`padrone/ink`. Vite's resolve.external list only had `padrone` and
`padrone/zod`, so the build broke after the recent entry-point split.
Add the new subpaths (ink, mcp, serve, tracing, completion, man) to
keep them external during SSR bundling.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 10, 2026

⚠️ No Changeset found

Latest commit: 5a325dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KurtGokhan KurtGokhan merged commit c2e2f9b into main May 10, 2026
1 check passed
@KurtGokhan KurtGokhan deleted the claude/fix-docs-build-externals branch May 10, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants