Stop creating useless file in home directory - resolves #82#84
Open
magnus-ISU wants to merge 1 commit intoKrispyCamel4u:masterfrom
Open
Stop creating useless file in home directory - resolves #82#84magnus-ISU wants to merge 1 commit intoKrispyCamel4u:masterfrom
magnus-ISU wants to merge 1 commit intoKrispyCamel4u:masterfrom
Conversation
Owner
|
Hi, there is a use of this file for using the theme_setter(for which rooter.py is required). It was done a long time before with a hackyy way of implementation when I was not aware of Glib::settings. But now as you reminded me, the purpose of this file can be greatly achieved with Glib::settings. |
Author
|
So should this branch be merged? Or is it breaking some functionality? |
Owner
|
This will break one functionality at the moment. So as of now, it can't be merged, but thanks for reminding this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be done with care. I see no reason why the program should have been doing this. However, maybe there was a reason and I haven't looked at the codebase hard enough.
That said, it runs exactly the same, and I can think of no reason why it should have been the way it was.