add tekufa methods#279
Closed
Elyahu41 wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Just thought of this: Should getTekufaName be renamed to formatTekufaName ? |
Owner
|
@Elyahu41 , that makes sense. Thanks |
Contributor
Author
|
Done @KosherJava |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the code to use newer Java Date Time classes. Also renamed the method getTekufaAsDate to getTekufaAsInstant.
Not sure about the Tekufa names String list in the HebrewDateFormatter Class. Let me know if it could be better or if it should just be left inside the method getTekufaName