Make jewish calendar thread safe#269
Merged
KosherJava merged 13 commits intoMay 6, 2026
Merged
Conversation
…nsit(Instant, Instant) - Also some JavaDoc cleanup
it is a drop too early.
delete obsolete dir and content
…ish-calendar-thread-safe
binyaz
pushed a commit
to binyaz/zmanim
that referenced
this pull request
Jun 28, 2026
* add synchronize to the JewishCalendar and JewishDate. One day we will try to make the classes immutable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds "synchronized" to 5 methods in the JewishCalendar and JewishDate classes. This should support devices running Java 9 and above without using more modern data structures, and it fixes an issue that could occur if there is a thread updating the internal date while the getParsha is being called.